Repository navigation
Keep Zapstore protocol out of this repository's checklist - #94
Merged
Merged
Conversation
An earlier attempt at this step documented relay event kinds and the version_code requirement, which is the action's internals leaking into the wrong repository. It would also rot as soon as the action changed how it reports. What is left asserts only what this repository owns: the publish step has to succeed, and zapstore.yaml points at CHANGELOG.md so a stale changelog publishes stale notes. pubkey, match, relay verification, credential rotation and how a publish is reported are all documented in rossigee/zapstore-publish, which is where a reader should be sent. One sms2webhook-specific fact is worth checking first: CHANGELOG.md is the source of the store's release notes, so step 2 is not optional.
🤖 Automated Code Review |
rossigee
added a commit
that referenced
this pull request
Oct 6, 2026
- versionCode 8, versionName "2.2.1" - New changelog entry documenting the post-2.2.0 fixes: - Activity log height in constrained viewports (PR #92) - Release checklist no longer leaks Zapstore internals (PR #94) - zapstore-publish prerequisite (v1.0.3 + @v1 update) already shipped so the 30 s timeout and documented fallback are live for this release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this replaces
#93, now closed. It added the four event kinds to the release checklist, including that
3063is the one carrying the APK. That is the action's internals in the wrongrepository, and it would rot the moment the action changed how it reports.
What was actually already documented elsewhere
I checked rather than assumed, and two of the three things I had written here were
already better documented in
rossigee/zapstore-publish:pubkeymust match the credential, is injected at publish time, a bunker credential carries its ownmatchpins the release asset so a debug build is never publishedrelease_notesfieldDuplicating the first two added nothing and created two places to rot.
What stays here, and why
Only what this repository owns:
skip-if-unconfigured: 'true'means a green rundoes not prove anything published, and the remedy is a re-run.
zapstore.yamlpoints atCHANGELOG.md, so step 2 is not optional. That is afact about a file in this repository, not about Zapstore.
wrong, that is a bug in the action — fix it there, not here.
verify-zapstore-signing.ymlstays mentioned because it is a workflow in thisrepository, even though what it proves is about the credential.
The one finding worth acting on elsewhere
Checking the third item turned up a real gap in
zapstore-publish: when no## [X.Y.Z]heading matches the APK's version,extractReleaseNotesreturns theentire file, not the previous section:
So SMS2Webhook v2.1.1 published every version's notes, headings and all — not merely
the previous release's. The behaviour is tested (
publish.test.ts:79) but neverdocumented. Filing that separately in the action's repo.