-
Notifications
You must be signed in to change notification settings - Fork 61
Bump Oracle to Free 23 and Instant Client to 23.26.1.0.0 #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
4576b5b
Bump Oracle to Free 23 (23.26.1) and Instant Client to 23.26.1.0.0
yahonda e8d0016
Fix Oracle 23c compatibility for BOOLEAN type
yahonda 43739b0
Update ORA-00942 test regex for Oracle 23c
yahonda 8c5045d
Add Ruby 3.3, 3.4 and 4.0 to CI test matrix
yahonda 32654f8
Bump Ruby version in RuboCop workflow to 4.0
yahonda 30fc3d0
Add CI workflow for Oracle Database 11g
yahonda 5d0515d
Bump activerecord and oracle_enhanced adapter to 8.0
yahonda 6e5593f
Remove Ruby 2.5-3.1 from CI test matrices
yahonda ee3a310
Bump RuboCop to latest and autocorrect offenses
yahonda c55253a
Use sqlplus from PATH instead of ORACLE_HOME/bin
yahonda c7ead1b
Register oracle_enhanced adapter for ActiveRecord 8.0 in specs
yahonda 7b6cfd7
Enable Ruby warnings in CI test runs
yahonda 4306dd3
Bump actions/checkout to v6
yahonda 962a2b5
Fix ActiveRecord 8.0 default_timezone API
yahonda e0dedbc
Require "logger" before "active_record" in spec helper
yahonda c0f1334
Fix frozen string literal warnings
yahonda 160f884
Fix Ruby warnings in specs
yahonda 56a6119
Replace deprecated :mswin, :mingw platforms with :windows
yahonda f91ffe4
Fix XMLType parameter and return value handling on Oracle 12c+
yahonda 62bd2e3
Use 11g server's v14 timezone file via ORA_TZFILE
yahonda b857812
Add Rails 5.0-8.0 gemfile matrix running minimum required CRuby
yahonda 8f80fd9
Remove Travis CI configuration
yahonda f4fe2b3
Remove .codeclimate.yml from gemspec s.files list
yahonda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| name: test_11g | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
| continue-on-error: true | ||
| strategy: | ||
| matrix: | ||
| ruby: [ | ||
| '4.0', | ||
| '3.4', | ||
| '3.3', | ||
| '3.2', | ||
| ruby-head, | ||
| ruby-debug, | ||
| truffleruby, | ||
| truffleruby-head | ||
| ] | ||
| env: | ||
| ORACLE_HOME: /opt/oracle/instantclient_21_15 | ||
| LD_LIBRARY_PATH: /opt/oracle/instantclient_21_15 | ||
| NLS_LANG: AMERICAN_AMERICA.AL32UTF8 | ||
| TNS_ADMIN: ./ci/network/admin | ||
| DATABASE_NAME: XE | ||
| TZ: Europe/Riga | ||
| DATABASE_SYS_PASSWORD: Oracle18 | ||
|
|
||
| services: | ||
| oracle: | ||
| image: gvenzl/oracle-xe:11 | ||
| ports: | ||
| - 1521:1521 | ||
| env: | ||
| TZ: Europe/Riga | ||
| ORACLE_PASSWORD: Oracle18 | ||
| options: >- | ||
| --health-cmd healthcheck.sh | ||
| --health-interval 10s | ||
| --health-timeout 5s | ||
| --health-retries 10 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| - name: Create symbolic link for libaio library compatibility | ||
| run: | | ||
| sudo ln -s /usr/lib/x86_64-linux-gnu/libaio.so.1t64 /usr/lib/x86_64-linux-gnu/libaio.so.1 | ||
| - name: Download Oracle instant client | ||
| run: | | ||
| wget -q https://download.oracle.com/otn_software/linux/instantclient/2115000/instantclient-basic-linux.x64-21.15.0.0.0dbru.zip | ||
| wget -q https://download.oracle.com/otn_software/linux/instantclient/2115000/instantclient-sqlplus-linux.x64-21.15.0.0.0dbru.zip | ||
| wget -q https://download.oracle.com/otn_software/linux/instantclient/2115000/instantclient-sdk-linux.x64-21.15.0.0.0dbru.zip | ||
| - name: Install Oracle instant client | ||
| run: | | ||
| sudo mkdir -p /opt/oracle/ | ||
| sudo unzip -q instantclient-basic-linux.x64-21.15.0.0.0dbru.zip -d /opt/oracle | ||
| sudo unzip -qo instantclient-sqlplus-linux.x64-21.15.0.0.0dbru.zip -d /opt/oracle | ||
| sudo unzip -qo instantclient-sdk-linux.x64-21.15.0.0.0dbru.zip -d /opt/oracle | ||
| echo "/opt/oracle/instantclient_21_15" >> $GITHUB_PATH | ||
| - name: Install JDBC Driver | ||
| run: | | ||
| wget -q https://download.oracle.com/otn-pub/otn_software/jdbc/233/ojdbc11.jar -O ./lib/ojdbc11.jar | ||
| - name: Configure ORA_TZFILE to match Oracle 11g server | ||
| run: | | ||
| # Oracle 11g XE uses timezone file v14; Instant Client 21.15 embeds v35. | ||
| # This mismatch causes ORA-01805 when ruby-oci8 fetches DATE/TIMESTAMP | ||
| # values. Copy the v14 files from the 11g container and point the | ||
| # Instant Client at them via ORA_TZFILE. | ||
| ORACLE_CONTAINER=$(docker ps --filter "ancestor=gvenzl/oracle-xe:11" -q) | ||
| sudo mkdir -p /opt/oracle/instantclient_21_15/oracore/zoneinfo | ||
| docker cp "$ORACLE_CONTAINER":/u01/app/oracle/product/11.2.0/xe/oracore/zoneinfo/timezlrg_14.dat /tmp/timezlrg_14.dat | ||
| docker cp "$ORACLE_CONTAINER":/u01/app/oracle/product/11.2.0/xe/oracore/zoneinfo/timezone_14.dat /tmp/timezone_14.dat | ||
| sudo mv /tmp/timezlrg_14.dat /opt/oracle/instantclient_21_15/oracore/zoneinfo/ | ||
| sudo mv /tmp/timezone_14.dat /opt/oracle/instantclient_21_15/oracore/zoneinfo/ | ||
| echo "ORA_TZFILE=timezlrg_14.dat" >> $GITHUB_ENV | ||
| - name: Create database user | ||
| run: | | ||
| ./ci/setup_accounts.sh | ||
| - name: Disable ActiveRecord for TruffleRuby | ||
| run: | | ||
| echo "NO_ACTIVERECORD=true" >> $GITHUB_ENV | ||
| if: "contains(matrix.ruby, 'truffleruby')" | ||
| - name: Bundle install | ||
| run: | | ||
| bundle install --jobs 4 --retry 3 | ||
| - name: Run RSpec | ||
| run: | | ||
| RUBYOPT=-w bundle exec rspec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| name: test_gemfiles | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - gemfile: gemfiles/Gemfile.activerecord-5.0 | ||
| ruby: '2.4' | ||
| - gemfile: gemfiles/Gemfile.activerecord-5.1 | ||
| ruby: '2.4' | ||
| - gemfile: gemfiles/Gemfile.activerecord-5.2 | ||
| ruby: '2.4' | ||
| - gemfile: gemfiles/Gemfile.activerecord-6.0 | ||
| ruby: '2.5' | ||
| - gemfile: gemfiles/Gemfile.activerecord-6.1 | ||
| ruby: '2.5' | ||
| - gemfile: gemfiles/Gemfile.activerecord-7.0 | ||
| ruby: '2.7' | ||
| - gemfile: gemfiles/Gemfile.activerecord-7.1 | ||
| ruby: '2.7' | ||
| - gemfile: gemfiles/Gemfile.activerecord-7.2 | ||
| ruby: '3.1' | ||
|
yahonda marked this conversation as resolved.
|
||
| - gemfile: gemfiles/Gemfile.activerecord-8.0 | ||
| ruby: '3.2' | ||
| env: | ||
| BUNDLE_GEMFILE: ${{ matrix.gemfile }} | ||
| ORACLE_HOME: /opt/oracle/instantclient_23_26 | ||
| LD_LIBRARY_PATH: /opt/oracle/instantclient_23_26 | ||
| NLS_LANG: AMERICAN_AMERICA.AL32UTF8 | ||
| TNS_ADMIN: ./ci/network/admin | ||
| DATABASE_NAME: FREEPDB1 | ||
| TZ: Europe/Riga | ||
| DATABASE_SYS_PASSWORD: Oracle18 | ||
|
|
||
| services: | ||
| oracle: | ||
| image: gvenzl/oracle-free:latest | ||
| ports: | ||
| - 1521:1521 | ||
| env: | ||
| TZ: Europe/Riga | ||
| ORACLE_PASSWORD: Oracle18 | ||
| options: >- | ||
| --health-cmd healthcheck.sh | ||
| --health-interval 10s | ||
| --health-timeout 5s | ||
| --health-retries 10 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: ${{ matrix.ruby }} | ||
| - name: Create symbolic link for libaio library compatibility | ||
| run: | | ||
| sudo ln -s /usr/lib/x86_64-linux-gnu/libaio.so.1t64 /usr/lib/x86_64-linux-gnu/libaio.so.1 | ||
| - name: Download Oracle instant client | ||
| run: | | ||
| wget -q https://download.oracle.com/otn_software/linux/instantclient/2326100/instantclient-basic-linux.x64-23.26.1.0.0.zip | ||
| wget -q https://download.oracle.com/otn_software/linux/instantclient/2326100/instantclient-sdk-linux.x64-23.26.1.0.0.zip | ||
| wget -q https://download.oracle.com/otn_software/linux/instantclient/2326100/instantclient-sqlplus-linux.x64-23.26.1.0.0.zip | ||
| - name: Install Oracle instant client | ||
| run: | | ||
| sudo unzip -q instantclient-basic-linux.x64-23.26.1.0.0.zip -d /opt/oracle/ | ||
| sudo unzip -qo instantclient-sdk-linux.x64-23.26.1.0.0.zip -d /opt/oracle/ | ||
| sudo unzip -qo instantclient-sqlplus-linux.x64-23.26.1.0.0.zip -d /opt/oracle/ | ||
| echo "/opt/oracle/instantclient_23_26" >> $GITHUB_PATH | ||
| - name: Install JDBC Driver | ||
| run: | | ||
| wget -q https://download.oracle.com/otn-pub/otn_software/jdbc/233/ojdbc11.jar -O ./lib/ojdbc11.jar | ||
| - name: Create database user | ||
| run: | | ||
| ./ci/setup_accounts.sh | ||
| - name: Bundle install | ||
| run: | | ||
| bundle install --jobs 4 --retry 3 | ||
| - name: Run RSpec | ||
| run: | | ||
| RUBYOPT=-w bundle exec rspec | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.