Refactor mess() for efficiency: pre-sort reference columns, vapply, deduplicate block loop - #35
Open
jeffery-leirness wants to merge 4 commits into
Open
Conversation
…eduplicate block loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #34 (should be merged first).
Developed with assistance from an AI coding assistant (Posit Assistant / Claude). All changes reviewed, tested, and verified by the PR author.
Changes in R/mess.R:
Extracted .messi_sorted() helper that assumes pre-sorted input, separating the sort step from the per-value computation
Reference columns are now sorted once before the block loop rather than on every iteration inside .messi()
Replaced sapply with vapply in multivariate paths for type-stable, slightly faster output
Deduplicated the full=TRUE/FALSE block loop branches into a single loop with a conditional only on the writeValues call
All existing tests pass.