Skip to content

feat: add rstack Codex plugin - #93

Draft
SoonIter wants to merge 1 commit into
mainfrom
feat-codex-rstackjs-plugin
Draft

feat: add rstack Codex plugin#93
SoonIter wants to merge 1 commit into
mainfrom
feat-codex-rstackjs-plugin

Conversation

@SoonIter

@SoonIter SoonIter commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

This PR lets Codex users install all public Rstack skills as one plugin:

codex plugin marketplace add rstackjs/agent-skills
codex plugin add rstack@rstack-skills

Why this layout

The skill source already lives in skills/. We compared three ways to package it as a plugin.

Copy

Used by openai/plugins:

agent-skills/
├── skills/                   # source
└── plugins/rstack/skills/    # second copy

Simple to package, but every skill is stored twice and the copies can get out of sync.

Symlink

Used by callstackincubator/agent-skills:

agent-skills/
├── skills/
└── plugins/rstack/skills/
    └── rspack-best-practices -> ../../../skills/rspack-best-practices

Avoids copies, but installation depends on symlink support.

Chosen: repository root

Used by obra/superpowers and this PR:

agent-skills/
├── .codex-plugin/plugin.json         # uses ./skills/
├── .agents/plugins/marketplace.json  # uses ./
└── skills/                           # single source

This keeps one copy of each skill and does not require symlinks. If a separate distribution bundle is needed later, it can be generated during publishing.

Related Links

Copilot AI review requested due to automatic review settings July 8, 2026 14:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e74304e451

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +10 to +11
"source": "url",
"url": "./"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a local source for the repo-root plugin

For users following the new README commands, Codex reads this marketplace from the cloned rstackjs/agent-skills repo. The official Codex Build plugins docs say repo/local marketplace entries should point source.path at the plugin directory relative to the marketplace root, while source: "url" is for Git-backed plugin sources; with url: "./" Codex cannot resolve this entry and skips it, so codex plugin add rstackjs@rstack-skills will not find/install the plugin. Use a local path source for the root manifest, e.g. source: "local" with path: "./".

Useful? React with 👍 / 👎.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This pull request adds Codex plugin support for the rstack-skills repository. It introduces a .codex-plugin/plugin.json manifest defining plugin metadata, skills entry point, and interface configuration with default prompts, along with a .agents/plugins/marketplace.json file registering the plugin under a marketplace with installation and authentication policies. The .gitignore file is updated to explicitly track the new marketplace configuration files. The README's Usage section is updated with instructions for installing all skills as a Codex plugin via marketplace and plugin add commands.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: adding the Rstack Codex plugin.
Description check ✅ Passed The description matches the changeset and explains the new Codex plugin packaging and install flow.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-codex-rstackjs-plugin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a Codex plugin manifest and a repo-local Codex plugin marketplace entry so Codex can install the repository’s public skills/ set as an installable plugin, and documents the installation steps in the README.

Changes:

  • Document Codex plugin installation commands in README.md.
  • Add a Codex plugin manifest at .codex-plugin/plugin.json that points to ./skills/.
  • Add a repo-local plugin marketplace file at .agents/plugins/marketplace.json and update .gitignore to keep it tracked.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
README.md Adds Codex plugin install instructions alongside existing npx skills add usage.
.gitignore Ensures the repo-local Codex plugin marketplace file remains tracked despite .agents/*** ignores.
.codex-plugin/plugin.json Declares the rstackjs Codex plugin and exposes ./skills/ as the skills source.
.agents/plugins/marketplace.json Adds a marketplace named rstack-skills with a single rstackjs plugin entry pointing at the repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/plugins/marketplace.json Outdated
Comment on lines +8 to +12
"name": "rstackjs",
"source": {
"source": "url",
"url": "./"
},
@SoonIter
SoonIter marked this pull request as draft July 9, 2026 04:07
@SoonIter
SoonIter force-pushed the feat-codex-rstackjs-plugin branch from e74304e to 3b6f4ec Compare July 9, 2026 07:40
@SoonIter
SoonIter force-pushed the feat-codex-rstackjs-plugin branch from 3b6f4ec to db6ed3d Compare July 20, 2026 07:01
@SoonIter SoonIter changed the title feat: add rstackjs Codex plugin feat: add rstack Codex plugin Jul 20, 2026
@SoonIter
SoonIter requested a review from Copilot July 22, 2026 08:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants