feat: add rstack Codex plugin - #93
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e74304e451
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "source": "url", | ||
| "url": "./" |
There was a problem hiding this comment.
Use a local source for the repo-root plugin
For users following the new README commands, Codex reads this marketplace from the cloned rstackjs/agent-skills repo. The official Codex Build plugins docs say repo/local marketplace entries should point source.path at the plugin directory relative to the marketplace root, while source: "url" is for Git-backed plugin sources; with url: "./" Codex cannot resolve this entry and skips it, so codex plugin add rstackjs@rstack-skills will not find/install the plugin. Use a local path source for the root manifest, e.g. source: "local" with path: "./".
Useful? React with 👍 / 👎.
📝 WalkthroughWalkthroughThis pull request adds Codex plugin support for the rstack-skills repository. It introduces a 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR introduces a Codex plugin manifest and a repo-local Codex plugin marketplace entry so Codex can install the repository’s public skills/ set as an installable plugin, and documents the installation steps in the README.
Changes:
- Document Codex plugin installation commands in
README.md. - Add a Codex plugin manifest at
.codex-plugin/plugin.jsonthat points to./skills/. - Add a repo-local plugin marketplace file at
.agents/plugins/marketplace.jsonand update.gitignoreto keep it tracked.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Adds Codex plugin install instructions alongside existing npx skills add usage. |
| .gitignore | Ensures the repo-local Codex plugin marketplace file remains tracked despite .agents/*** ignores. |
| .codex-plugin/plugin.json | Declares the rstackjs Codex plugin and exposes ./skills/ as the skills source. |
| .agents/plugins/marketplace.json | Adds a marketplace named rstack-skills with a single rstackjs plugin entry pointing at the repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "name": "rstackjs", | ||
| "source": { | ||
| "source": "url", | ||
| "url": "./" | ||
| }, |
e74304e to
3b6f4ec
Compare
3b6f4ec to
db6ed3d
Compare
Summary
This PR lets Codex users install all public Rstack skills as one plugin:
Why this layout
The skill source already lives in
skills/. We compared three ways to package it as a plugin.Copy
Used by
openai/plugins:Simple to package, but every skill is stored twice and the copies can get out of sync.
Symlink
Used by
callstackincubator/agent-skills:Avoids copies, but installation depends on symlink support.
Chosen: repository root
Used by
obra/superpowersand this PR:This keeps one copy of each skill and does not require symlinks. If a separate distribution bundle is needed later, it can be generated during publishing.
Related Links