Skip to content

fix: export package.json - #49

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-package-json-export
Jul 28, 2026
Merged

fix: export package.json#49
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-package-json-export

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

@rspack/lite-tapable/package.json cannot currently be resolved because the package export map only exposes the root entry. This PR exports ./package.json and adds regression coverage for package subpath resolution.

Related Links

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 84beee6c-b038-48af-9a96-063ae642ac59

📥 Commits

Reviewing files that changed from the base of the PR and between 952d2aa and c3e07f9.

📒 Files selected for processing (2)
  • package.json
  • test/PackageExports.test.js

📝 Walkthrough

Walkthrough

The package exports map adds an explicit ./package.json subpath pointing to the package manifest. A Jest test requires @rspack/lite-tapable/package.json and verifies that its name field is @rspack/lite-tapable.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: exporting package.json from the package.
Description check ✅ Passed The description directly matches the changes by explaining the new package.json export and regression test coverage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/fix-package-json-export

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan
chenjiahan merged commit 70bc667 into main Jul 28, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/fix-package-json-export branch July 28, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant