Conversation
Co-authored-by: Néstor <Nsttt@users.noreply.github.com>
Co-authored-by: Néstor <Nsttt@users.noreply.github.com>
Co-authored-by: Néstor <Nsttt@users.noreply.github.com>
chenjiahan
left a comment
chenjiahan
left a comment
There was a problem hiding this comment.
It looks like we don't need to trigger website deployment from the release workflow. The standalone Deploy Website workflow should be sufficient. Could we remove the website deployment job from release.yml and keep deployment in deploy-website.yml?
chenjiahan
left a comment
chenjiahan
left a comment
There was a problem hiding this comment.
Two additional issues with the Zephyr integration:
| cleanUrls: true, | ||
| }, | ||
| plugins: [ | ||
| withZephyr({ target: 'web' }), |
There was a problem hiding this comment.
Could we enable this plugin only when explicitly deploying, using an environment flag set by the deployment workflow? In zephyr-rspress-plugin@1.4.0, the SSG plugin initializes the Zephyr engine even in development mode, so pnpm doc attempts authentication and pnpm doc:build attempts deployment. Ordinary local documentation development and builds should work without Zephyr credentials or deployment side effects.
| cleanUrls: true, | ||
| }, | ||
| plugins: [ | ||
| withZephyr({ target: 'web' }), |
There was a problem hiding this comment.
Could we ensure sitemap.xml is generated before Zephyr collects the files to upload? Both the Zephyr SSG plugin and pluginSitemap use afterBuild, and Rspress runs these hooks in parallel. In a minimal reproduction using the actual plugins and file traversal, with authentication and upload mocked, the upload file list omitted sitemap.xml in all 20 runs even though it existed on disk afterward. We need to sequence sitemap generation before file collection; reordering the plugins alone will not resolve the race.
This branch has not been deployed
3 participants
Motivation
Deploy the Rstack CLI documentation through Zephyr, following the Rsbuild website setup, with main builds and stable-release production promotion.
Changes
Add the Zephyr Rspress plugin and site org config. Deploy main to Zephyr with the CI token; after a successful
latestnpm release, deploy the exact released source commit to production.Validation:
pnpm build,pnpm --filter rstack build:native, andpnpm checkpassed. The website compiled, but local Zephyr Build ID creation lacked access to the new site identity. The full test run had one docs-restart timeout under parallel load; its focused rerun passed. Pre-commit autoreview was clean. CI requires repository secretZE_CI_TOKENand Zephyr access forrstack-website.rstack-cli.rstack.