chore(test): remove NO_COLOR workaround for Rstest - #526
Merged
Merged
Conversation
Rstest no longer injects FORCE_COLOR into test workers since @rstest/core 0.12.2, so the test config no longer needs to disable colors.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
9b67e6d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://467fcf1b.rstack-cli.pages.dev |
| Branch Preview URL: | https://chore-remove-rstest-color-wo.rstack-cli.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b67e6dca1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chenjiahan
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rstest used to inject
FORCE_COLOR=1into test worker processes (on a TTY or withCI=true) unless the host already had a color env set.process.env.NO_COLOR = '1'in the rstack test config was there to stop that injection, so CLI output assertions stayed plain.Since
@rstest/core0.12.2 (web-infra-dev/rstest#1893), Rstest no longer writes any color env into workers. The catalog already requires~0.12.2.Changes
Remove the
NO_COLORoverride frompackages/rstack/rstack.config.ts. WithCI=true, the full suite passes without it; on@rstest/core0.12.1, 76 tests fail without it.delete env.FORCE_COLORin the fmt test helpers is kept: Node'sstyleTextgivesFORCE_COLORprecedence overNO_COLOR, so it still protects spawned CLI output whenFORCE_COLORcomes from the user's shell or CI.