feat(vscode): sync the standalone Rslint and Rstest extensions - #74
Conversation
Bring the unified extension up to rslint e5d76242 (0.9.3) and rstest 41daaa1b (0.12.2) before the standalone extensions retire. - Report ESLint-plugin host failures through the Rslint status instead of upstream's toast: a missing plugin package is the not-installed state (disabled), any other failure is crashed with a one-line detail; the dependency poll recovers both. - Let the shared missing-dependency classifier accept a Node module-not-found message after a `: ` wrapper on the first line. - Ship generated third-party notices as LICENSE.md in the VSIX. - Upgrade yuku-parser to 0.12.0. - Port the live, privacy-aware trace setting wording and the fixAll typed-diagnostic E2E waits.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da2ba03c02
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 331656453a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcc13391ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Syncs the unified extension with the latest standalone extensions before they are retired: web-infra-dev/rslint
packages/vscode-extensionthrough e5d76242 (0.9.3) and web-infra-dev/rstestpackages/vscodethrough 41daaa1b (0.12.2). A manifest-level audit found no missing user-facing capability; this PR ports the remaining gaps.plugins; our worker only logged it, so the status stayedrunningwhile every plugin rule silently reported nothing. The worker now reports every such failure through a dedicatedpluginverdict, shown asdisabledwithESLint plugins failed to load: <first line>(deliberately unclassified); the full error goes to Output once per episode, and the dependency poll recovers it. Status returns torunningonly when a ready plugin-host generation commits. New E2E suitePlugin-host failure.webpack-license-pluginto each bundle (extension,worker,lint-worker) and ship its JSON notices (dist/<id>.licenses.json) next to the copied rootLICENSE. The copied Yuku native binding is listed viaincludePackages.yuku-parser0.8.3 → 0.12.0 (0.11 removed walker/codegen entry points we do not use).trace.serversetting wording (applied to fmt too). Rslint 72cd2b1f: fixAll E2E typed-diagnostic waits.packages/vscode/AGENTS.mdrecords the new upstream baseline and the adaptation notes.Verified locally:
pnpm lint && pnpm test:unit, the full lint and rstest E2E slices, thevscodeslice, and a packaged darwin-arm64 VSIX.Related Links
Checklist