fix(vscode)!: launch the Rstest worker under js-debug when debugging - #76
Conversation
Let js-debug own the worker and pool processes, using a debug-only local socket for JSON RPC while normal runs retain Node IPC. Bound startup and close the session on cancellation, transport failure, or worker disposal. Cover real breakpoints with port 9229 occupied and verify process cleanup after continuing, cancelling, and stopping the debug session. BREAKING CHANGE: remove rstack.rstest.debuggerPort and rstack.rstest.debuggerAddress without aliases or migration. js-debug manages inspector endpoints automatically. Amp-Thread-ID: T-01a0ec42-b8e2-71ba-b623-05b375f9e885
Remove redundant launch state, listeners, and timeout handling. Share the debug socket environment key and keep unit coverage focused on behavior not already exercised by the real debug E2E suite. Record debugger-owned test processes as an upstream adaptation. Amp-Thread-ID: T-01a0ec42-b8e2-71ba-b623-05b375f9e885
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25a4296edb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fi3ework
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3dbce7d7b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1fd3f9e93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Debugging a test from Test Explorer spawned the Rstest worker with a bare
--inspect-waitand attached with a numericprocessId, which js-debug does not resolve, so the attach always went tolocalhost:9229. When 9229 was already taken (another debug session, a dev server started with--inspect), Node printedaddress already in use, ran the tests without waiting, and breakpoints never hit.Debug runs now use js-debug
request: 'launch':nodeExecutable→runtimeExecutable,nodeExecArgs→runtimeArgs,nodeEnv/debugNodeEnv→env,debugExclude→skipFiles,debugOutFiles→outFiles.Breaking:
rstack.rstest.debuggerPortandrstack.rstest.debuggerAddressare removed. Under launch they have nothing to control.The divergence from the upstream standalone extension is recorded as adaptation 11 in
packages/vscode/AGENTS.md.Related Links
Checklist