feat(vscode)!: leave preview and unify corePath settings - #77
Merged
Merged
Conversation
BREAKING CHANGE: rstack.rstest.rstestPackagePath was renamed to rstack.rstest.corePath. The old key is no longer read. Both corePath settings accept a package directory or a package.json path.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4513ab1fb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares
rstack.rstackfor its first non-preview release."preview": truefrom the extension manifest.rstack.rstest.rstestPackagePathtorstack.rstest.corePath, matchingrstack.rslint.corePath.corePathsettings now accept either the core package directory (e.g.node_modules/@rstest/core) or itspackage.json. Previously the Rstest setting only accepted apackage.jsonpath and the Rslint setting only a directory.Breaking:
rstack.rstest.rstestPackagePathis no longer read. Setrstack.rstest.corePathinstead; an existingpackage.jsonvalue can be moved over unchanged.Related Links
Checklist
package.jsonform, relative paths,${workspaceFolder}expansion (Rstest) and invalid paths for both settings, in worker and Run in Terminal resolution. The lintcore-resolverE2E exercises both forms through a real VS Code host.