Feat: Add PMS User settings doctype and API

[saranshsinhaa]

Description

• Adds a PMS User setting doctype to keep track of the configurable settings throughout PMS for individual users
• Adds API to get, create and update the documents for Employees
• Adds a field as system default expanded view in Timesheet Settings doctype

Relevant Technical Choices

• Adds a get_or_create endpoint which create a new document for an employee on the first get request and on subsequent requests simply returns the fields
• Added a update endpoint which update the fields for that employee

Checklist

• I have carefully reviewed the code before submitting it for review.
• This code is adequately covered by unit tests to validate its functionality.
• I have conducted thorough testing to ensure it functions as intended.
• A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Part of: #2101 , #1776

Required for: #2125

[Copilot]

Pull request overview

Adds per-user PMS settings storage and APIs for retrieving and updating employee preferences.

Changes:

• Introduces the PMS User Setting DocType.
• Adds get-or-create and update endpoints with input validation.
• Adds placeholder controller and integration-test files.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pms_user_setting/__init__.py	Initializes the DocType package.
pms_user_setting/pms_user_setting.json	Defines fields and permissions.
pms_user_setting/pms_user_setting.py	Implements settings APIs and validation.
pms_user_setting/pms_user_setting.js	Adds the generated client controller scaffold.
pms_user_setting/test_pms_user_setting.py	Adds an empty integration-test scaffold.

Suppressed comments (1)

next_pms/next_pms/doctype/pms_user_setting/pms_user_setting.json:23

• read_only only protects the Desk UI; it does not make this identity field immutable on the server. Because Employees have owner-scoped write access at permlevel 0, an owner can update user through the generic resource API and reserve another user's unique value, causing that user's get-or-create flow to fail. Protect user with a higher permlevel granted only to System Manager, or reject changes to it in the controller.

   "read_only": 1,
   "reqd": 1,
   "unique": 1

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Suppressed comments (1)

next_pms/next_pms/doctype/pms_user_setting/test_pms_user_setting.py:20

• This test class is empty despite introducing stateful GET/POST endpoints with permission checks, first-read creation, fallback behavior, and input validation. Add integration tests for those paths, including unauthorized users and rejected negative/non-integer or unsupported values, so regressions in per-user isolation are detected.

    pass