Add: storybook + seo component + gutneberg style package#65
Add: storybook + seo component + gutneberg style package#65bilouStrike wants to merge 5 commits intomasterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rtcamp/wp-decoupled/n3leu30cu |
|
@bilouStrike try not to overdo things and keep PRs seperate . its faster and easier to manage things this way |
| "prettier": "^2.2.1", | ||
| "serialize-javascript": "^2.1.2" | ||
| } | ||
| "name": "wp-decoupled", |
There was a problem hiding this comment.
dont format the package.json
NicestRudeGuy
left a comment
NicestRudeGuy
left a comment
There was a problem hiding this comment.
please resolve the conflict
| ) | ||
| )} | ||
| <> | ||
| <NextSeo |
There was a problem hiding this comment.
Please add a todo to make the seo data dynamic, that would later come from WordPress
| import { NextSeo } from 'next-seo'; | ||
|
|
||
| const NewProducts = ({ products }) => { | ||
| return ( |
There was a problem hiding this comment.
Please add Prop types for products, using prop-types npm package
pages/index.js
Outdated
| <span className="product-link"> | ||
| <img | ||
| className="product-image" | ||
| src={item.image.sourceUrl} |
There was a problem hiding this comment.
use optional chaining
item?.image?.sourceUrl
| "@storybook/addon-essentials": "^6.1.14", | ||
| "@storybook/addon-links": "^6.1.14", | ||
| "@storybook/react": "^6.1.14", | ||
| "@wordpress/base-styles": "^3.3.0", |
There was a problem hiding this comment.
Where are we using this package?
@wordpress/base-styles, we need to import it in sass file
… into setup-packages pul merge
3 participants
This PR aims to close #60 #53