Add "always show" interaction mode for quest translations#12
Open
Kenneth-Audenaert wants to merge 2 commits intorubenzantingh:retailfrom
Open
Add "always show" interaction mode for quest translations#12Kenneth-Audenaert wants to merge 2 commits intorubenzantingh:retailfrom
Kenneth-Audenaert wants to merge 2 commits intorubenzantingh:retailfrom
Conversation
Make UpdateQuestTranslationFrame global so language packs can trigger it from events/hooks. Skip the IsMouseOver() check when the interaction mode is set to "always", and prevent OnLeave from hiding the translation frame in that mode. This enables language packs (e.g. MultiLanguage_NL) to register an "always show" interaction option that displays quest translations without requiring hover, while leaving existing hover/hotkey behavior completely unchanged. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
To include this in the main addon the merge request needs to contain all functionalities to make this possible. That means that the interaction mode option should be added within this merge request, because it would otherwise require the MultiLaguage_NL addon to work. I also want people who have no interest in the Dutch language to be able to use this. |
Move the "always show" feature entirely into the core addon so it works for all users without requiring a language pack. Adds translated labels for all 10 supported languages, registers the option in defaults, and handles QUEST_LOG_UPDATE and QuestMapDetailsScrollFrame show/hide events. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Kenneth-Audenaert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alwaysas a built-in interaction option alongsidehoverandhover-hotkeyQUEST_LOG_UPDATEevents andQuestMapDetailsScrollFrameshow/hide to auto-update translations in "always" modeUpdateQuestTranslationFrameglobal so language packs can also call it from their own hooksIsMouseOver()check when "always" is selectedOnLeavefrom hiding the translation frame when "always" mode is activeMotivation
Some users prefer to see quest translations at all times rather than only on hover. This adds "always show" as a complete, self-contained feature in the core addon — no language pack required.
Test plan
🤖 Generated with Claude Code