Skip to content

concurrent-ruby-ext: fix build on Darwin 32-bit #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barracuda156 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

concurrent-ruby-ext: fix build on Darwin 32-bit #1064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ext/concurrent-ruby-ext/atomic_reference.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,15 @@ VALUE ir_get_and_set(VALUE self, VALUE new_value) {

VALUE ir_compare_and_set(volatile VALUE self, VALUE expect_value, VALUE new_value) {
#if defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) && __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ >= 1050
#if defined(__i386__) || defined(__ppc__)
if (OSAtomicCompareAndSwap32(expect_value, new_value, &DATA_PTR(self))) {
Copy link
Member

@eregon eregon Dec 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (OSAtomicCompareAndSwap32(expect_value, new_value, &DATA_PTR(self))) {
if (OSAtomicCompareAndSwap32(expect_value, new_value, (VALUE*) &DATA_PTR(self))) {

Can you try this?
I think it should solve your warning on Ruby 3.2

return Qtrue;
}
#else
if (OSAtomicCompareAndSwap64(expect_value, new_value, &DATA_PTR(self))) {
return Qtrue;
}
#endif
#elif defined(__sun)
/* Assuming VALUE is uintptr_t */
/* Based on the definition of uintptr_t from /usr/include/sys/int_types.h */
Expand Down