Skip to content

Reject incomplete JRuby cursor responses - #158

Merged
nobu merged 1 commit into
ruby:masterfrom
OskarEichler:codex/jruby-cursor-response
Sep 4, 2026
Merged

Reject incomplete JRuby cursor responses#158
nobu merged 1 commit into
ruby:masterfrom
OskarEichler:codex/jruby-cursor-response

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary

Return nil unless JRuby's cursor query receives a terminating response with exactly two coordinates.

Reproduction

Focused external cursor models feed EOF and incomplete single-coordinate responses. Current code returns partial/decremented arrays; the candidate rejects them.

Verification

  • external EOF/incomplete/valid cursor models
  • release/cumulative candidate: 36 tests / 143 assertions
  • current upstream: 35 tests / 144 assertions
  • syntax, package builds and Rails 8.1.3.1 loading

Compatibility

Valid row/column responses are unchanged. JRuby was modeled but is unavailable locally; current upstream CI is green on JRuby. Prepared with AI-assisted source review; no repository tests were changed.

@nobu
nobu force-pushed the codex/jruby-cursor-response branch from 4f6d0c2 to 8a6fda1 Compare September 4, 2026 00:57
@nobu
nobu merged commit 27fde7f into ruby:master Sep 4, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants