Iterate over symbols to get the number to avoid array creation#101
Open
krzysiek1507 wants to merge 1 commit intoruby:masterfrom
Open
Iterate over symbols to get the number to avoid array creation#101krzysiek1507 wants to merge 1 commit intoruby:masterfrom
krzysiek1507 wants to merge 1 commit intoruby:masterfrom
Conversation
Author
|
Hey @yui-knk is this PR worth merging? |
56a16e2 to
d57654c
Compare
Collaborator
|
@krzysiek1507 Thanks for your PR. However I think this is not bottleneck of current Lrama. If it's not bottleneck, I want to keep current codes because it's intuitive for me. By the way, this is how to take profiling for real world use case, generating parser for ruby/ruby. 1. Create
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny optimisation that reduces the memory usage by eliminating an array that it not used later anyway.
For parsing
spec/fixtures/context/basic.yit reduces one object:Before:
After: