Set up rbs_collection.yaml and add a TypeProf-generated prototype rbs#19
Open
mame wants to merge 13 commits intoruby:masterfrom
Open
Set up rbs_collection.yaml and add a TypeProf-generated prototype rbs#19mame wants to merge 13 commits intoruby:masterfrom
mame wants to merge 13 commits intoruby:masterfrom
Conversation
Collaborator
|
Just curiosity, how did you generated these files? |
yui-knk
reviewed
May 17, 2023
| VERSION: String | ||
| include Comparable | ||
|
|
||
| def to_s: -> String |
Collaborator
There was a problem hiding this comment.
I suspect these methods comes from Lrama::Rule, which is a struct,
Line 7 in 4a58968
Is this intentional?
yui-knk
reviewed
May 17, 2023
sig/lrama/typeprof-generated.rbs
Outdated
| attr_writer accept_symbol: bot | ||
| def term?: -> untyped | ||
| def nterm?: -> untyped | ||
| def eof_symbol?: -> false |
Member
Author
I did: |
Contributor
|
https://cookpad.connpass.com/event/282436/
|
Collaborator
|
PR & コメントありがとうございます。その後のmameさんcommitを踏まえたうえでの感想ですが
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.