Replace Timeout.timeout with Socket.tcp(..., open_timeout:)#223
Closed
osyoyu wants to merge 1 commit intoruby:masterfrom
Closed
Replace Timeout.timeout with Socket.tcp(..., open_timeout:)#223osyoyu wants to merge 1 commit intoruby:masterfrom
osyoyu wants to merge 1 commit intoruby:masterfrom
Conversation
This patch replaces the implementation of #open_timeout from Timeout.timeout from the builtin timeout in Socket.tcp, which was introduced in Ruby 3.5 (https://bugs.ruby-lang.org/issues/21347). The builtin timeout in Socket.tcp is better in several ways. First, it does not rely on a separate Ruby Thread for monitoring Timeout (which is what the timeout library internally does). Also, it is compatible with Ractors, since it does not rely on Mutexes (which is also what the timeout library does). This change allows the following code to work. require 'net/http' Ractor.new { uri = URI('http://example.com/') http = Net::HTTP.new(uri.host, uri.port) http.open_timeout = 1 http.get(uri.path) }.value
Contributor
Author
|
The failing test is caused by https://bugs.ruby-lang.org/issues/21512. We can wait until it gets fixed |
3059071 to
00cb12b
Compare
Contributor
Author
|
Replaced by #224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6.
This patch replaces the implementation of #open_timeout from Timeout.timeout from the builtin timeout in Socket.tcp, which was introduced in Ruby 3.5 (https://bugs.ruby-lang.org/issues/21347).
The builtin timeout in Socket.tcp is better in several ways. First, it does not rely on a separate Ruby Thread for monitoring Timeout (which is what the timeout library internally does). Also, it is compatible with Ractors, since it does not rely on Mutexes (which is also what the timeout library does).
This change allows the following code to work.
In Ruby <3.5 environments where
Socket.tcpdoes not have theopen_timeoutoption, I have kept the behavior unchanged. net/http will useTimeout.timeout { TCPSocket.open }.Changes in behavior
The raised
Net::OpenTimeout's message has slightly changed, and also carrys aErrno::ETIMEDOUTas its cause. I can keep the message compatible if needed.Previously, it looked like this.