Allow Net::HTTP.get, get_response, post, post_form, put to receive URI String#24
Open
kyanagi wants to merge 3 commits intoruby:masterfrom
Open
Allow Net::HTTP.get, get_response, post, post_form, put to receive URI String#24kyanagi wants to merge 3 commits intoruby:masterfrom
Net::HTTP.get, get_response, post, post_form, put to receive URI String#24kyanagi wants to merge 3 commits intoruby:masterfrom
Conversation
Member
|
For consistency, supporting the same thing for |
c639473 to
7a4dc8d
Compare
Author
|
@k0kubun |
|
This looks cool, @k0kubun Does this have any blockers ? |
Member
|
I left a comment because I contributed a similar feature, but I'm not the maintainer. You need to ping the actual maintainer https://github.com/ruby/ruby/blob/master/doc/maintainers.md#libnethttprb-libnethttpsrb after fixing the conflict. |
7a4dc8d to
0674aef
Compare
Net::HTTP.get, get_response, post, post_form, put to receive URI String
Author
|
I resolved the conflicts. @nurse What do you think of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to pass a
URIobject toNet::HTTP.get_response(orNet::HTTP.get).With this patch, these methods can receive a URI-string.