Add pattern matching support to Net::HTTPGenericRequest#241
Open
baweaver wants to merge 4 commits intoruby:masterfrom
Open
Add pattern matching support to Net::HTTPGenericRequest#241baweaver wants to merge 4 commits intoruby:masterfrom
baweaver wants to merge 4 commits intoruby:masterfrom
Conversation
Implements deconstruct_keys to enable pattern matching on HTTP requests
based on method, path, and other request attributes.
Example:
case request
in method: 'POST', path: %r{^/api/}
handle_api_request(request)
in method: 'GET', path: '/'
handle_root
end
baweaver
commented
Nov 9, 2025
| req = Net::HTTP::Post.new(uri) | ||
|
|
||
| begin | ||
| matched = instance_eval <<~RUBY, __FILE__, __LINE__ + 1 |
Contributor
Author
There was a problem hiding this comment.
This was a similar trick as to what we had used around pattern matching for the 2.6 to 2.7 push, so I'm repeating it here. The other methods should function even without syntax bridges like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds deconstruct_keys to Net::HTTPGenericRequest, enabling pattern matching on HTTP request attributes.
(Moved from ruby/ruby#15111)
Usage
Implementation
• Added
PATTERN_MATCHING_KEYSconstant defining valid keys: method, path, uri, body, content_type• Implemented
deconstruct_keysfollowing Ruby pattern matching best practices• Returns only requested keys when specified, all valid keys when keys is
nil