Open
Conversation
Contributor
Author
|
@tmtm Thanks for taking the time to review all of my PRs! I've split this PR out from #71, because the other changes in that PR are not as important or uncontroversial as these changes. However, the tests for this code are still in that PR. Please let me know if you'd like me to make any changes (e.g: adding tests directly to this PR or changing anything about the API). Thanks! |
nevans
force-pushed
the
sasl/forward-keyword-args
branch
from
d229999 to
7a6f2f1
Compare
This adds a new `auth` keyword param to `Net::SMTP.start` and `#start` that can be used to pass any arbitrary keyword parameters to `#authenticate`. The pre-existing `username`, `secret`, etc keyword params will retain their existing behavior as positional arguments to `#authenticate`.
nevans
force-pushed
the
sasl/forward-keyword-args
branch
from
7a6f2f1 to
2dd30e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.startand#startnow take anauthkeyword argument, which is an optional hash of keyword arguments that will be forwarded to#authenticate.#authenticatenow forwards its keyword arguments (and its block argument) to its chosen authenticator.Note: this isn't tested in this PR because the tests I originally wrote for it don't work without authenticators that accept keyword arguments. This PR doesn't update existing authenticators or adding any new authenticator. See #71.