Skip to content

Conversation

@hsbt
Copy link
Member

@hsbt hsbt commented Feb 6, 2026

Fixes #564

Copilot AI review requested due to automatic review settings February 6, 2026 02:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #564 by replacing the anonymous Struct used for application options with a named Rake::Options class. This improves error messages by showing Rake::Options instead of #<Class:0x...> when undefined methods are called on the options object.

Changes:

  • Created a new Rake::Options class with all 20 option attributes from the original Struct
  • Updated Application#options to instantiate Options.new instead of the anonymous Struct
  • Added appropriate require statements in both lib/rake.rb and lib/rake/application.rb

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
lib/rake/options.rb New file defining the Rake::Options class with attr_accessors for all 20 application options
lib/rake/application.rb Updated options method to use Options.new instead of anonymous Struct, added require statement
lib/rake.rb Added require statement for the new Options class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make options a named class?

1 participant