Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rbs/ast/type_param.rb
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def self.subst_var(vars, type)
def self.rename(params, new_names:)
raise unless params.size == new_names.size

subst = Substitution.build(new_names, Types::Variable.build(new_names))
subst = Substitution.build(params.map(&:name), Types::Variable.build(new_names))

params.map.with_index do |param, index|
new_name = new_names[index]
Expand Down
24 changes: 24 additions & 0 deletions test/rbs/ast/type_param_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,28 @@ def test_normalize_args
assert_equal ["::Integer", "::Array[::Integer]", "::Array[::Array[::Integer]]"], args.map(&:to_s)
end
end

def test_rename
params = [
TypeParam.new(name: :A, variance: :covariant, upper_bound: nil, lower_bound: nil, location: nil),
TypeParam.new(
name: :B,
variance: :invariant,
upper_bound: parse_type("::Array[A]"),
lower_bound: nil,
default_type: parse_type("::Hash[A, B]"),
location: nil
).unchecked!
]

TypeParam.rename(params, new_names: [:X, :Y]).tap do |renamed|
assert_equal [:X, :Y], renamed.map(&:name)
assert_equal :covariant, renamed[0].variance
assert_equal :invariant, renamed[1].variance
assert_predicate renamed[1], :unchecked?

assert_equal parse_type("::Array[X]", variables: [:X]), renamed[1].upper_bound_type
assert_equal parse_type("::Hash[X, Y]", variables: [:X, :Y]), renamed[1].default_type
end
end
end
Loading