Conversation
Add DeclId, SingleEntry, and DuplicatedDeclarationError types, and insert.rs to track interface declarations per source and report duplicates as load errors instead of silently overwriting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dak2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2954. First slice of the
Environmentdeclaration-table layer (Ruby'sinsert_rbs_decl): registersinterfacedeclarations and reports duplicates as load errors, matchingRBS::DuplicatedDeclarationError.Porting all of
environment.rbat once (class/module reopening, constants, aliases, normalization) would mix several independent quirks into one review. This PR is scoped tointerfaceonly, top level only; class/module nesting,Context, and the other tables are follow-up PRs of similar size.🤖 Generated with Claude Code