Repository navigation
Conversation
The TCP fallback after a truncated reply connected with no time limit, so a nameserver dropping SYNs blocked for the OS connect timeout and raised IO::TimeoutError. Bound the connect by the timeout and treat a timed out connect like a refused one, moving on to the next nameserver. Reported by: irevivalx (https://hackerone.com/irevivalx) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
shioimm
approved these changes
Oct 24, 2026
| @port = port | ||
| sock = TCPSocket.new(@host, @port) | ||
| sock = if connect_timeout && RUBY_VERSION >= "3.0" | ||
| TCPSocket.new(@host, @port, connect_timeout: connect_timeout) |
There was a problem hiding this comment.
On Ruby 4.0 and later, open_timeout is available, which times out based on the time elapsed since the start of the method call.
However, for the purpose of this change, I think it's fine to keep connect_timeout, which times out based on the time elapsed since the start of the last connection attempt.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TCP fallback after a truncated reply connected with no time limit, so a nameserver dropping SYNs blocked for the OS connect timeout and raised IO::TimeoutError. Bound the connect by the timeout and treat a timed out connect like a refused one, moving on to the next nameserver.
Reported by: irevivalx (https://hackerone.com/irevivalx)