Conversation
hsbt
left a comment
There was a problem hiding this comment.
Can you remove Dockerfile and related changes? I don't use that.
If you interest that to use develop RubyGems, please consider to integrate the current devcontainer support of this repository.
|
@hsbt Dear Hiroshi, I'll make just this one attempt to convince you to keep the setup. |
|
I agree with @hsbt that this is not something we're looking to adopt currently. |
|
OK, @hsbt, please confirm, and I'll immediately remove these 39 lines from the 200K+(!) LoC project that might help casual contributors (who are definitely not "we") with a single entry point to running all the tests, having a single dependency (the ubiquitous Docker) at that. No problem. |
|
Please remove them at first. |
abd45e7 to
5510c62
Compare
@hsbt done |
...by a little code duplication; specs are somewhat improved though
5510c62 to
9cf802a
Compare
…up-from-7547-dumb-http-git-repo-support-broken
…t-repo-support-broken
|
@hsbt LGTM |
|
ping |
…t-repo-support-broken
|
@hsbt Yes, and? Please? |
|
In my understanding with #7547, Why would you want to git clone and use it via a local http server without using the |
…t-repo-support-broken
This PR fixes a bug with rubygems functionality which I believe should support everything git supports. Now, serving git repos with dumb HTTP servers (read-only) is useful in many low-profile scenarios. In my "self server" (docker-host-based) case, illustrated here: https://medium.com/@costa/git-decentralized-a25f00fd2955 -- when I serve git repos via dumb HTTP, this uses simple p2p sharing stack -- and enables p2p git-based communication, as well as makes container builds straightforward. |
…t-repo-support-broken
|
@hsbt Hi, how're you doing? Now, this PR is one of the oldest open ones. I've just updated its branch. How can I help you with accepting or rejecting it? Thank you. |
What was the end-user or developer problem that led to this PR?
See #9001
What is your fix for the problem, implemented in this PR?
Duplicate the functionality implemented in #7547
Make sure the following tasks are checked
p.s. Oh, and also containerised (with docker) test env was added.