Add pattern matching support to Gem::Platform#9062
Merged
hsbt merged 2 commits intoruby:masterfrom Nov 12, 2025
Merged
Conversation
|
|
||
| alias_method :deconstruct, :to_a | ||
|
|
||
| def deconstruct_keys(keys) |
Member
There was a problem hiding this comment.
Similar to #9060, could we add a few lines of documentation to provide a quick explanation.
hsbt
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Ruby 2.7+ introduced pattern matching, but
Gem::Platformdoes not support it. This makes platform-specific conditional logic more verbose than necessary, particularly when routing gem installations or filtering platforms.The current approach requires multiple conditionals or case statements with equality checks:
What is your fix for the problem, implemented in this PR?
Added
deconstructanddeconstruct_keysmethods toGem::Platformto enable pattern matching syntax.Implementation:
deconstructaliases the existingto_amethod for array pattern matching, returning[cpu, os, version]deconstruct_keysreturns a hash with keys:cpu,:os, and:versionThis enables platform-based pattern matching:
Or extracting specific components:
Make sure the following tasks are checked