Improve handling of paths with invalid Windows characters#9276
Open
Saidbek wants to merge 3 commits intoruby:masterfrom
Open
Improve handling of paths with invalid Windows characters#9276Saidbek wants to merge 3 commits intoruby:masterfrom
Saidbek wants to merge 3 commits intoruby:masterfrom
Conversation
Add validation and clear error messages for gems with filenames containing invalid Windows characters (e.g., colons), directing users to report issues to gem authors instead of RubyGems.
Saidbek
force-pushed
the
improve-windows-filename-handling
branch
from
bbb7488 to
c9af675
Compare
Saidbek
force-pushed
the
improve-windows-filename-handling
branch
from
d8abe69 to
a8dfff3
Compare
larskanis
reviewed
Feb 11, 2026
larskanis
reviewed
Feb 11, 2026
Saidbek
force-pushed
the
improve-windows-filename-handling
branch
from
f92a344 to
d8371bf
Compare
larskanis
reviewed
Feb 14, 2026
| # Note: Colons are only valid as drive letter separators (e.g., C:), not in filenames. | ||
|
|
||
| def invalid_windows_filename?(filename) # :nodoc: | ||
| return false unless Gem.win_platform? |
Contributor
There was a problem hiding this comment.
This disables the invalid character check on other platforms than Windows. So the intention to warn authors on other systems doesn't work. It warns only on Windows.
larskanis
reviewed
Feb 14, 2026
| full_name = entry.full_name | ||
| next unless File.fnmatch pattern, full_name, File::FNM_DOTMATCH | ||
|
|
||
| if invalid_windows_filename?(full_name) |
Contributor
There was a problem hiding this comment.
The platform check should be here:
if Gem.win_platform? && invalid_windows_filename?(full_name)
larskanis
reviewed
Feb 15, 2026
| end | ||
|
|
||
| def test_build_warns_on_invalid_windows_filename | ||
| pend "Windows filename validation only applies on Windows" unless Gem.win_platform? |
Contributor
There was a problem hiding this comment.
This should be the other way around:
pend "Windows filename validation only applies on non-Windows" if Gem.win_platform?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is your fix for the problem, implemented in this PR?
Fixes #7681
Windows doesn't allow certain characters in filenames (e.g., colons) that are valid on Unix. When gems contain files with these characters, installation fails on Windows with cryptic
Errno::EINVALerrors.This PR adds validation and directs users to report issues to gem authors instead.
InvalidFileNameErrorwith user-friendly messagesMake sure the following tasks are checked