Skip to content

Do not create unnecessary directories #9313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 2 commits into from
Feb 9, 2026
+0 −8
Merged

Do not create unnecessary directories #9313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b62e46
Revert "Cleaned up bundler .gem and .gemspec files in ensure block."
nobu Feb 6, 2026
725f4ff
Do not create unnecessary directories
nobu Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions bundler/spec/commands/clean_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,12 +913,10 @@ def should_not_have_gems(*gems)
# Simulate that the locked bundler version is installed in the bundle path
# by creating the gem directory and gemspec (as would happen after bundle install with that version)
Pathname(vendored_gems("cache/bundler-#{version}.gem")).tap do |path|
path.basename.mkpath
FileUtils.touch(path)
end
FileUtils.touch(vendored_gems("gems/bundler-#{version}"))
Pathname(vendored_gems("specifications/bundler-#{version}.gemspec")).tap do |path|
path.basename.mkpath
path.write(<<~GEMSPEC)
Gem::Specification.new do |s|
s.name = "bundler"
Expand All @@ -934,11 +932,5 @@ def should_not_have_gems(*gems)
bundle :clean

should_have_gems "bundler-#{version}"
ensure
["bundler-#{version}.gem", "bundler-#{version}.gemspec"].each do |filename|
Pathname(vendored_gems(filename)).tap do |path|
FileUtils.rm_rf(path.basename)
end
end
end
end