Skip to content

Avoid reinstalling bundler if the required version is already installed #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntkme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid reinstalling bundler if the required version is already installed #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bundler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,10 @@ export async function installBundler(bundlerVersionInput, rubygemsInputSet, lock
const gem = path.join(rubyPrefix, 'bin', 'gem')

const versionParts = [...bundlerVersion.matchAll(/\d+/g)].length
const bundlerVersionConstraint = versionParts >= 3 ? bundlerVersion : `~> ${bundlerVersion}.0`
// Use --conservative to avoid reinstalling the exact same version if already installed.
const options = versionParts >= 3 ? ['-v', bundlerVersion, '--conservative'] : ['-v', `~> ${bundlerVersion}.0`]

@ntkme ntkme Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use --conservative for a precise version requirement, so that ~> will always check for updates.

@eregon eregon Oct 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but could you add a comment?
--conservative is usually used for to avoid upgrading what doesn't need to be and this is a bit of a special case: avoid reinstalling the same version to avoid concurrency issues as described in #951.

@ntkme ntkme Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.


await exec.exec(gem, ['install', 'bundler', '-v', bundlerVersionConstraint])
await exec.exec(gem, ['install', 'bundler', ...options])

return bundlerVersion
}
Expand Down
5 changes: 3 additions & 2 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading