Skip to content

Filter comments by System vs admin author; credit automatic notes to System - #2930

Merged
maebeale merged 4 commits into
mainfrom
maebeale/comments-filter-dropdown-add
Nov 4, 2026
Merged

maebeale merged 4 commits into
mainfrom
maebeale/comments-filter-dropdown-add

Conversation

@maebeale

@maebeale maebeale commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 new comment scope + automatic notes stop crediting the admin who triggered them

This feature is mainly for me as I work w the import data, but will be of use to staff for similar reasons

Admins can filter comments to just System notes or just staff-written ones, and notes the portal writes on its own now count as System instead of reading as an admin's own words.

  • Author type dropdown — All authors / Admin / System on the All comments page and a person's comments page.
    • System = no created_by; Admin = has one.
  • Automatic notes write as System — via Comment.create_as_system!.
    • It clears Current.user so UserStampable doesn't stamp the signed-in admin.
    • Covers registrant import, story import, program closure, affiliation reconciliation, login-email sync.
    • Imported records themselves (registrations, stories, payments) still credit the admin who ran the import.
    • FileMaker imports run as rake tasks with no signed-in user, so their notes were already System.
  • Comment count contrast — text-gray-400 → text-gray-600 on the blue admin background.
  • CI security scan — fails here until Bump rack and addressable for bundler-audit advisories #2931 (rack bump) merges.
  • Existing notes — handled by a one-time console backfill outside the repo, not a migration.

🤖 Generated with Claude Code

@maebeale maebeale changed the title Filter comments by System vs admin author Filter comments by System vs admin author; credit import notes to System Oct 31, 2026
@maebeale
maebeale marked this pull request as ready for review November 1, 2026 02:17
@maebeale maebeale changed the title Filter comments by System vs admin author; credit import notes to System Filter comments by System vs admin author; credit automatic notes to System Nov 1, 2026
@maebeale
maebeale force-pushed the maebeale/comments-filter-dropdown-add branch from 11e540a to 0153b71 Compare November 2, 2026 12:28
maebeale and others added 4 commits November 4, 2026 08:40
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Import-written notes were credited to whichever admin ran the import, so
they read as that person's own words and couldn't be told apart from real
staff comments. Imports now write their notes as System, and the comment
filters can show just one kind.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
These notes record what the portal did on its own, so crediting them to the
admin whose click triggered them made them read as that admin's words.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@maebeale
maebeale force-pushed the maebeale/comments-filter-dropdown-add branch from 0153b71 to a3b4d97 Compare November 4, 2026 13:42
@maebeale
maebeale merged commit ec42c2d into main Nov 4, 2026
3 checks passed
@maebeale
maebeale deleted the maebeale/comments-filter-dropdown-add branch November 4, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant