Repository navigation
Show transfer money at the event of the registration holding it - #2952
Merged
Merged
Conversation
maebeale
marked this pull request as ready for review
November 5, 2026 16:28
Money on a transferred registration was missing from event reports: the old reg wasn't active and the new reg was excluded as transferred in. Money is tracked apart from attendance, so each allocation now counts at the event of the reg it sits on, and a balance left is owed at the new event. The dashboard, revenue report, and scholarship report share that basis, so they agree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/transfer-monies-reports-bug
branch
from
November 5, 2026 16:34
7cb0818 to
80d704c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 5 Inspect 🔬 changes the money basis behind the dashboard, revenue report, and scholarship report
Closes #2947
Money on transferred registrations now shows on event reports, because it was missing from both events even though we'd received it.
What changes
Worth a close look
RegistrationBalances— bulk twin of the one-balance rule in Let transferred registrants pay their balance on the new registration #2945, so it doesn't need Let transferred registrants pay their balance on the new registration #2945 to merge first. Checked againstremaining_coston a double transfer with Let transferred registrants pay their balance on the new registration #2945 and Send old tickets to the new registration's balance #2949 applied.EventDashboard#total_cents— removed. Only specs used it.Not changed
Features seed
UI Testing Checklist
🤖 Generated with Claude Code