Add coverage for CreateCasaAdminService#6820
Open
stefannibrasil wants to merge 1 commit intorubyforgood:mainfrom
Open
Add coverage for CreateCasaAdminService#6820stefannibrasil wants to merge 1 commit intorubyforgood:mainfrom
stefannibrasil wants to merge 1 commit intorubyforgood:mainfrom
Conversation
stefannibrasil
force-pushed
the
sb-admin-user-creation-coverage-6818
branch
3 times, most recently
from
74af503 to
6b1f7db
Compare
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
CreateCasaAdminService creates admin users with org setup but has a placeholder spec only. This commit adds coverage for it since creating users is a critical functionality of the app.
stefannibrasil
force-pushed
the
sb-admin-user-creation-coverage-6818
branch
from
6b1f7db to
cb35b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Closes #6818
What changed, and why?
CreateCasaAdminService creates admin users with org setup but has a placeholder spec only.
This commit adds coverage for it since creating users is a critical functionality of the app.