chore: reference internal actions/* via $/, not a version pin - #114
Merged
Merged
Conversation
collect-issues-shared.yml, collect-pull-requests-shared.yml, and proposal-shared.yml pinned their own sibling composite actions to explicit tags (v0.5/v0.6) or @main, requiring a manual bump in lockstep with every release -- the exact churn dependabot's #81 was chasing. rubykatzen/baseline's own shared workflows (e.g. lint-shared.yml) instead reference sibling actions via $/, which resolves to this repository at the same ref the caller pinned for the shared workflow itself. Adopting it here means these internal references can no longer drift out of sync with a release, and never need bumping again. Supersedes #81. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collect-issues-shared.yml,collect-pull-requests-shared.yml, andproposal-shared.ymlreferenced their own sibling composite actions (actions/collect-issues,actions/collect-pull-requests,actions/proposal,actions/telegram-notify) via explicit version pins (@v0.5,@v0.6) or@main— requiring a manual bump every release, which is exactly the churn Dependabot's chore(deps): bump rubykatzen/starcast from 0.2 to 0.8 #81 was chasingrubykatzen/baseline's own shared workflows (e.g.lint-shared.yml) instead reference sibling actions via$/, which resolves to "this repository, at the same ref the caller pinned for the shared workflow itself" — confirmed working today, since starcast already callslint-shared.yml@v0.18.1successfully and it internally uses$/.github/actions/...throughout (see https://github.com/orgs/community/discussions/111928 for background on the syntax)actions/proposal's old@mainpin, since there's no longer a tag to "switch back to"Supersedes #81 (closing that PR separately, since it just bumped the old pins to
v0.8rather than removing them).Test plan
pre-commithooks (yamllint, pymarkdown, actionlint) pass on the commitproposal-shared.yml'sapply/reject/proposejobs (orcollect-issues-shared.yml/collect-pull-requests-shared.yml) end-to-end from a real caller to confirm$/resolves as expected in production, not just inlint-shared.yml