Skip to content

Conversation

@Khaled2143
Copy link

Bank Watcher is a utility plugin that tracks your bank’s value, monitors quantity and price changes, and highlights the biggest gainers and losers in your stash. It provides daily-limited scans, compares current values against your last snapshot, and shows clean visual breakdowns of GE price, total value, deltas, and quantity changes.

Includes plugin metadata pointing to the bank-watcher repository and the latest commit hash. This enables the Plugin Hub to fetch and build the BankWatcher plugin from my repo. No other files modified.
@runelite-github-app
Copy link

runelite-github-app bot commented Nov 28, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Nov 29, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Member

riktenx commented Dec 7, 2025

Do either of these plugins satisfy your needs, or are you willing to contribute to them if they don't?

Contribution to existing plugins is preferred but not required. If the answer to the above is no then we can review this as-is.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 7, 2025
@Khaled2143
Copy link
Author

https://runelite.net/plugin-hub/show/bank-value-changes

This plugin is similar to what I am looking for and would love for the chance to contribute and add my own touches.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 10, 2025
@Infinitay
Copy link
Contributor

Infinitay commented Dec 10, 2025

Would it be better to instead rely on RuneLite's API to fetch the item prices? You can also fetch it according to the wiki via ItemManager#getItemPriceWithSource. the prices? I believe we also cache which is why I am suggesting it in the first place to avoid spamming the wiki for price checks anytime the bank is opened. Oh sorry, I just saw it relies on the user manually clicking a button to add an entry and that you're rate limiting the user on the scans/manual entries they can perform. I believe using RL's API would also avoid the limitations placed on the users of your plugin. Though I would get verification just in case.

@riktenx
Copy link
Member

riktenx commented Dec 10, 2025

If you're interested in contributing then please reach out to the other plugin author and let them know. For now we can keep this in waiting-for-author state, if for whatever reason your contribution efforts don't work out we can still review this as-is if desired.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 10, 2025
@Khaled2143
Copy link
Author

Hi, I've decided that I'd like to go ahead and continue with the review of this PR.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 31, 2025
@riktenx
Copy link
Member

riktenx commented Jan 3, 2026

do not ever call sleep on the client thread, you will freeze the game

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added size-0 waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants