-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New Plugin: Bank Watcher #9658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New Plugin: Bank Watcher #9658
Conversation
Includes plugin metadata pointing to the bank-watcher repository and the latest commit hash. This enables the Plugin Hub to fetch and build the BankWatcher plugin from my repo. No other files modified.
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Do either of these plugins satisfy your needs, or are you willing to contribute to them if they don't?
Contribution to existing plugins is preferred but not required. If the answer to the above is no then we can review this as-is. |
|
https://runelite.net/plugin-hub/show/bank-value-changes This plugin is similar to what I am looking for and would love for the chance to contribute and add my own touches. |
|
Would it be better to instead rely on RuneLite's API to fetch the item prices? You can also fetch it according to the wiki via ItemManager#getItemPriceWithSource. the prices? I believe we also cache which is why I am suggesting it in the first place |
|
If you're interested in contributing then please reach out to the other plugin author and let them know. For now we can keep this in waiting-for-author state, if for whatever reason your contribution efforts don't work out we can still review this as-is if desired. |
|
Hi, I've decided that I'd like to go ahead and continue with the review of this PR. |
|
do not ever call sleep on the client thread, you will freeze the game |
Bank Watcher is a utility plugin that tracks your bank’s value, monitors quantity and price changes, and highlights the biggest gainers and losers in your stash. It provides daily-limited scans, compares current values against your last snapshot, and shows clean visual breakdowns of GE price, total value, deltas, and quantity changes.