Dev rich man - #1717
Merged
Merged
Conversation
- 新增 check_true_orochi_enable 配置项控制是否启用检测 - 御魂挑战结束后检测真蛇, 发现则立即触发 TrueOrochi 任务
- 新增 enable_book_auto 配置项, 控制永生之海是否使用自动选择 - _scales_sea 根据配置分支: 开启时使用 _scales_buy_more(自动选择), 关闭时使用原 _scales_buy_sea_more(手动选魂) - 补充 zh-CN 国际化文案
- config: 新增 earn_money 配置项控制是否执行借处流程 - thousand_things: 新增 tt_earn_money 方法，实现借出式神并领取500樱灯饰 - assets: 新增 borrow/configure/confirm/shikigami 等图像匹配资源 - i18n: 补充 zh-CN 国际化文案
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我在这里给出了一些高层次的反馈：
- 新的
tt_earn_money流程依赖于一个无限的while 1循环，只有在I_TT_SHIKIGAMI_REPLACE消失时才会退出；建议添加超时时间或最大迭代次数，以避免在 UI 进入意外状态时发生卡死。 I_TT_CONFIGURE和I_TT_CONFIRM使用了相同的 ROI 和文件路径；你可以复用同一个资源，或者添加说明性注释，以避免造成它们是不同按钮的误解。
给 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- The new `tt_earn_money` flow relies on an infinite `while 1` loop that only exits when `I_TT_SHIKIGAMI_REPLACE` disappears; consider adding a timeout or maximum iteration count to avoid hanging if the UI gets into an unexpected state.
- Both `I_TT_CONFIGURE` and `I_TT_CONFIRM` share identical ROI and file paths; you could reuse a single asset or add a clarifying comment to avoid confusion about whether they represent distinct buttons.帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈改进后续的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- The new
tt_earn_moneyflow relies on an infinitewhile 1loop that only exits whenI_TT_SHIKIGAMI_REPLACEdisappears; consider adding a timeout or maximum iteration count to avoid hanging if the UI gets into an unexpected state. - Both
I_TT_CONFIGUREandI_TT_CONFIRMshare identical ROI and file paths; you could reuse a single asset or add a clarifying comment to avoid confusion about whether they represent distinct buttons.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `tt_earn_money` flow relies on an infinite `while 1` loop that only exits when `I_TT_SHIKIGAMI_REPLACE` disappears; consider adding a timeout or maximum iteration count to avoid hanging if the UI gets into an unexpected state.
- Both `I_TT_CONFIGURE` and `I_TT_CONFIRM` share identical ROI and file paths; you could reuse a single asset or add a clarifying comment to avoid confusion about whether they represent distinct buttons.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
@runhey |
Owner
|
可以，大不了开一个新的函数，我当时图快，写这个好像就一天 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
在《大富翁·千本事》中新增可选的自动赚金币流程，并增强大蛇副本流程以可选地检测和安排真·大蛇任务，同时优化大富翁秤与通用购买交互。
New Features:
Bug Fixes:
Enhancements:
Original summary in English
Summary by Sourcery
Add optional automated money-earning flow in RichMan Thousand Things and enhance Orochi runs to optionally detect and schedule True Orochi, while refining RichMan scales and generic buy interactions.
New Features:
Bug Fixes:
Enhancements: