Automated PR 2026.08.06 - #1724
Open
github-actions[bot] wants to merge 8 commits into
Open
Conversation
…sing AttributeError
- 新增 check_true_orochi_enable 配置项控制是否启用检测 - 御魂挑战结束后检测真蛇, 发现则立即触发 TrueOrochi 任务
- 新增 enable_book_auto 配置项, 控制永生之海是否使用自动选择 - _scales_sea 根据配置分支: 开启时使用 _scales_buy_more(自动选择), 关闭时使用原 _scales_buy_sea_more(手动选魂) - 补充 zh-CN 国际化文案
- config: 新增 earn_money 配置项控制是否执行借处流程 - thousand_things: 新增 tt_earn_money 方法,实现借出式神并领取500樱灯饰 - assets: 新增 borrow/configure/confirm/shikigami 等图像匹配资源 - i18n: 补充 zh-CN 国际化文案
Dev rich man
There was a problem hiding this comment.
Hey - 我在这里留下了一些高层面的反馈:
- 新增的
goto_shikigami_records和exit_shikigami_records方法使用了没有超时或最大重试次数的while 1循环,如果 UI 状态或资源发生变化,就有可能导致任务挂起;建议增加一个Timer/尝试计数器或兜底路径,以避免出现无限循环。 - 在
tt_earn_money中,你调用了self.ui_get_reward(self.I_TT_BORROW_CONFIRM),但当前模块已经定义了一个tt_get_reward辅助方法,而且在这个类继承层级中似乎没有明显的ui_get_reward方法;请仔细检查并将调用调整为现有的 TT 专用奖励辅助方法,以避免在运行时出现属性错误。
面向 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- The new `goto_shikigami_records` and `exit_shikigami_records` methods use `while 1` loops without any timeout or max retries, which risks hanging the task if the UI state or assets change; consider adding a `Timer`/attempt counter or fallback path to avoid infinite loops.
- In `tt_earn_money`, you call `self.ui_get_reward(self.I_TT_BORROW_CONFIRM)`, but this module already defines a `tt_get_reward` helper and there is no obvious `ui_get_reward` method in this class hierarchy; double-check and align the call to the existing TT-specific reward helper to prevent attribute errors at runtime.帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈改进之后的评审。
Original comment in English
Hey - I've left some high level feedback:
- The new
goto_shikigami_recordsandexit_shikigami_recordsmethods usewhile 1loops without any timeout or max retries, which risks hanging the task if the UI state or assets change; consider adding aTimer/attempt counter or fallback path to avoid infinite loops. - In
tt_earn_money, you callself.ui_get_reward(self.I_TT_BORROW_CONFIRM), but this module already defines att_get_rewardhelper and there is no obviousui_get_rewardmethod in this class hierarchy; double-check and align the call to the existing TT-specific reward helper to prevent attribute errors at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `goto_shikigami_records` and `exit_shikigami_records` methods use `while 1` loops without any timeout or max retries, which risks hanging the task if the UI state or assets change; consider adding a `Timer`/attempt counter or fallback path to avoid infinite loops.
- In `tt_earn_money`, you call `self.ui_get_reward(self.I_TT_BORROW_CONFIRM)`, but this module already defines a `tt_get_reward` helper and there is no obvious `ui_get_reward` method in this class hierarchy; double-check and align the call to the existing TT-specific reward helper to prevent attribute errors at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…vent infinite loop #1723
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR created by GitHub Actions. Merge dev into master
Summary by Sourcery
将新的换魂流程集成到多个任务中,扩展大蛇流程以在需要时可选触发真大蛇,并为财神新增自动化选项,同时优化 UI 资源定义与配置。
New Features:
Bug Fixes:
Enhancements:
Original summary in English
Summary by Sourcery
Integrate new soul-switching flows into multiple tasks, extend Orochi runs to optionally trigger TrueOrochi, and add new RichMan automation options while refining UI asset definitions and configs.
New Features:
Bug Fixes:
Enhancements: