feat: add native plugin and hook sync#138
Open
talvaknin744 wants to merge 3 commits intorunkids:mainfrom
Open
Conversation
…nment feat: add native plugin and hook sync
There was a problem hiding this comment.
Code Review
This pull request introduces native integrations for Claude and Codex through new plugin and hook management systems, including CLI commands for listing, importing, and syncing these resources. The changes update core commands like status, diff, and sync --all to support these integrations and provide comprehensive documentation and testing utilities. Feedback focuses on improving robustness and performance, specifically addressing silent error handling in configuration discovery, inefficient JSON and file I/O operations, and fragile string parsing or TOML editing logic that could lead to panics or incorrect behavior.
Owner
|
Thanks for the PR! I'll take a closer look and try it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pluginsandhookssource/sync flows for Claude and Codexstatus,diff,doctor, andsync --allBehavior Notes
hooks sync --target allkeeps successful rows plus warning/no-op rows such asno codex hooks defineduse full refVerification
make fmtmake fmt-checkmake lintmake buildmake checkmake test-redteam./scripts/test_docker.sh./scripts/test_docker_online.shpassed locally; token/private-repo cases were skipped withoutGITHUB_TOKENcd website && npm run buildplugins import/list/synchooks import/list/syncstatus --jsondiff --jsondoctor --jsonsync --all --jsonclaudebinaryAdditional Note
make checkRefs #133