Remove ABI assertion for Windows imports#744
Merged
ChrisDenton merged 1 commit intorust-lang:masterfrom Jan 19, 2026
Merged
Conversation
Contributor
Author
|
Failures are rust-lang/rust#141470, opened #745 |
clubby789
force-pushed
the
no-detect-abi
branch
from
ec76819 to
a17ca20
Compare
meta-codesync bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Jan 28, 2026
Summary: Using a git dependency a few commits after 0.3.76 in order to pull in rust-lang/backtrace-rs#744, which fixes a build error on Windows when using `cfg(windows_raw_dylib)`. ```lang=log,counterexample error[E0308]: mismatched types --> third-party\rust\vendor\backtrace-0.3.76\src\dbghelp.rs:87:76 | 35 | / macro_rules! dbghelp { 36 | | (extern "system" { 37 | | $(fn $name:ident($($arg:ident: $argty:ty),*) -> $ret: ty;)* 38 | | }) => ( ... | 87 | | let _: unsafe extern "C" fn($($argty),*) -> $ret = super::windows_sys::$name; | | ----------------------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^ expected "C" fn, found "system" fn | | | | | expected due to this ... | 126 | | } | |_- in this expansion of `dbghelp!` 127 | 128 | / dbghelp! { 129 | | extern "system" { 130 | | fn SymGetOptions() -> u32; 131 | | fn SymSetOptions(options: u32) -> u32; ... | 223 | | } | |_- in this macro invocation | = note: expected fn pointer `unsafe extern "C" fn(_, _) -> _` found fn item `unsafe extern "system" fn(_, _) -> _ {windows_sys::SymAddrIncludeInlineTrace}` ``` Difference from 0.3.76: rust-lang/backtrace-rs@backtrace-v0.3.76...df979dc Context: https://fb.workplace.com/groups/learningrust/posts/4270473293223523 Reviewed By: cjlongoria Differential Revision: D91645033 fbshipit-source-id: 5c7131a86b89090e9d72f2aa82b5d918065d029b
meta-codesync bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Jan 28, 2026
Summary: Using a git dependency a few commits after 0.3.76 in order to pull in rust-lang/backtrace-rs#744, which fixes a build error on Windows when using `cfg(windows_raw_dylib)`. ```lang=log,counterexample error[E0308]: mismatched types --> third-party\rust\vendor\backtrace-0.3.76\src\dbghelp.rs:87:76 | 35 | / macro_rules! dbghelp { 36 | | (extern "system" { 37 | | $(fn $name:ident($($arg:ident: $argty:ty),*) -> $ret: ty;)* 38 | | }) => ( ... | 87 | | let _: unsafe extern "C" fn($($argty),*) -> $ret = super::windows_sys::$name; | | ----------------------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^ expected "C" fn, found "system" fn | | | | | expected due to this ... | 126 | | } | |_- in this expansion of `dbghelp!` 127 | 128 | / dbghelp! { 129 | | extern "system" { 130 | | fn SymGetOptions() -> u32; 131 | | fn SymSetOptions(options: u32) -> u32; ... | 223 | | } | |_- in this macro invocation | = note: expected fn pointer `unsafe extern "C" fn(_, _) -> _` found fn item `unsafe extern "system" fn(_, _) -> _ {windows_sys::SymAddrIncludeInlineTrace}` ``` Difference from 0.3.76: rust-lang/backtrace-rs@backtrace-v0.3.76...df979dc Context: https://fb.workplace.com/groups/learningrust/posts/4270473293223523 Reviewed By: cjlongoria Differential Revision: D91645033 fbshipit-source-id: 5c7131a86b89090e9d72f2aa82b5d918065d029b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#727 updated to using
windows-linkoverwindows-targets, but retained the ABI-assertion check from #677. This behaviour was removed in windows-link 0.2 (microsoft/windows-rs#3741), and this leads to broken builds (rust-lang/rust#149124 (comment))