Conversation
Muscraft
force-pushed
the
image-cleanup
branch
from
fee7592 to
d13c961
Compare
Kobzol
reviewed
Oct 3, 2025
Member
Kobzol
left a comment
Kobzol
left a comment
There was a problem hiding this comment.
Went through the commits, everything looked reasonable. Left one question.
Dockerfile-debian.template
Outdated
| rm rustup-init; \ | ||
| chmod -R a+w $RUSTUP_HOME $CARGO_HOME; \ | ||
| \ | ||
| apt-get purge -y --auto-remove -o APT::AutoRemove::RecommendsImportant=false; \ |
Member
There was a problem hiding this comment.
In Dockerfile-slim, you remove wget, here you remove.. everything? Or what does apt-get purge without an argument do?
Member
Author
There was a problem hiding this comment.
I was mistaken about what this change did, and am going to drop it in favor of getting the other changes in.
I had hoped that apt-get purge -y --auto-remove wget would remove wget, anything unnecessary, as well as package metadata, but it appears it doesn't.
Muscraft
force-pushed
the
image-cleanup
branch
from
d13c961 to
7791344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at some of
docker-library'sDockerfiles, I realized that our currentDockerfileformat could be improved, and we should try to roughly match theirs. This PR is a collection of changes that hopefully make things better.References:
docker/28/cli/Dockerfilegcc/15/Dockerfilejulia/1.11/trixie/Dockerfilephp/8.4/trixie/cli/Dockerfilepostgres/18/trixie/Dockerfilepypy/3.11/trixie/Dockerfile--progress=dot:gigacc @Kobzol, @sfackler