Document asm_cfg inline assembly attributes#653
Merged
kirtchev-adacore merged 13 commits intorust-lang:mainfrom Mar 10, 2026
Merged
Document asm_cfg inline assembly attributes#653kirtchev-adacore merged 13 commits intorust-lang:mainfrom
kirtchev-adacore merged 13 commits intorust-lang:mainfrom
Conversation
Contributor
Author
|
Hey @tshepang, @kirtchev-adacore -- could this be reviewed? |
c7f1f37 to
da682f3
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
kirtchev-adacore
requested changes
Mar 3, 2026
kirtchev-adacore
requested changes
Mar 6, 2026
kirtchev-adacore
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asm_cfgattribute support on inline assembly templates/operands and update the inline-assembly grammarReference alignment
cfgconditions on inline assembly templates and operands reference#2063AsmAttrFormatString/AsmAttrOperand; FLS introducesAssemblyTemplate/AssemblyAttribute*wrappers to match, splitting operands intoRegisterArgument,AbiClobber, andAssemblyOptioncfg/cfg_attrsupport and the template-first rule match the Reference; FLS makes cfg-false argument behavior explicit to align with conditional compilation semanticsTesting