Skip to content

Use criterion for benches#243

Closed
henryboisdequin wants to merge 2 commits intorust-lang:masterfrom
henryboisdequin:bench
Closed

Use criterion for benches#243
henryboisdequin wants to merge 2 commits intorust-lang:masterfrom
henryboisdequin:bench

Conversation

@henryboisdequin
Copy link

Closes #4

@henryboisdequin henryboisdequin requested a review from Amanieu March 3, 2021 00:49
@Amanieu
Copy link
Member

Amanieu commented Mar 3, 2021

You need to fix the CI failures. And restore the benchmark code that you deleted (the function are created by the macro_rules!, but you deleted it).

@bors
Copy link
Contributor

bors commented Mar 14, 2021

☔ The latest upstream changes (presumably edeb8f7) made this pull request unmergeable. Please resolve the merge conflicts.

@clarfonthey
Copy link
Contributor

This appears to be superceded by #609, so, closing.

@clarfonthey clarfonthey closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Making benchmarks better

4 participants