always use stable Rust to build josh#31
Merged
Kobzol merged 1 commit intorust-lang:mainfrom Nov 16, 2025
Merged
Conversation
Member
|
FWIW, one of the original motivations for this tool was to ensure that everyone will be using the same version of Josh, and more specifically a version that is up-to-date, as we all remember what happened when an out-of-date version was used :D Having a CLI opt-out to not install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not a huge fan of having josh installed automatically -- that's a global change to my system that IMO a tool shouldn't do without first asking me, and it makes it impossible to use the tool with a local, experimental version of josh (this
cargo installwill always downgrade it back to the released version). However, I am even more not a fan of having that build done with whatever random toolchain happens to be active when I invoke josh-sync. At the very least, let's make sure we use a stable version of Rust, not some nightly snapshot.