Allow defining inline structs in diagnostics!#21798
Open
ada4a wants to merge 2 commits intorust-lang:masterfrom
Open
Allow defining inline structs in diagnostics!#21798ada4a wants to merge 2 commits intorust-lang:masterfrom
diagnostics!#21798ada4a wants to merge 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
I personally think the old way is fine, and don't want this change. |
Member
|
Not sure about the complexity, but that enum is a bit weird, do we still want it to be an enum in the long run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a random TODO comment I thought I'd implement. I have some doubts about this though:
pubandstructreally worth it? I feel like one'd write them almost instinctively and be surprised when it doesn't work. Maybe I could adjust the macro to look for$($($vis:vis)? strukt:ident)?instead?Also, the diff is pretty hard to review, sorry about that. I found that commenting out
IncorrectCasehelped a little bit, hence the second commit that uncomments it.