feat: supports minus to underscore rename#21801
Open
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Open
feat: supports minus to underscore rename#21801A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
A4-Tacks wants to merge 1 commit intorust-lang:masterfrom
Conversation
Example
---
Rename to `"a-b"`
```rust
fn main() { let i$0 = 1; }
```
**Before this PR**
Invalid name `a-b`: not an identifier
**After this PR**
```rust
fn main() { let a_b = 1; }
```
lnicola
reviewed
Mar 11, 2026
Member
Author
This feature is very useful, but there seems to be no other LSP or IDE implementation PyCharm, jedils, tsserver, luals, ocamllsp and clangd have not implemented this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing minus is usually much more convenient than typing underscore
Example
Rename to
"a-b"Before this PR
Invalid name
a-b: not an identifierAfter this PR