Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
rvalue_promotable_mapin [1]fix [2] according to this comment Simplify ExprUseVisitor rust#64874 (comment) this should be merged withconsume, but I didn't figure out how to merge them, yet.fix [3]; What to do withLoanCause?[2]+[3] probably have to be resolved by a rewrite of the lint. #4628 (comment)
[1]
rust-clippy/clippy_lints/src/methods/mod.rs
Lines 1292 to 1299 in 54bf4ff
[2]
rust-clippy/clippy_lints/src/escape.rs
Line 126 in 54bf4ff
[3]
rust-clippy/clippy_lints/src/escape.rs
Lines 166 to 176 in 54bf4ff
I could need some help with [1]. The purpose of this is to "don't lint for constant values". cc @matthewjasper
For now I see what I can do with [2].
changelog: Temporary break
boxed_locallint.