Skip to content

Suggest using MCP and RFC for substancial changes #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apiraino wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −6
Open

Suggest using MCP and RFC for substancial changes #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/compiler/proposals-and-stabilization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
# Proposals, Approvals and Stabilization
It is very common to need to gather feedback and approval when contributing to the compiler, either
for permission to proceed with an experiment or refactoring, or when stabilizing a feature. This
document aims to summarise the various processes that the compiler team has for making approval
decisions and when each should be used.
for permission to proceed with an experiment or refactoring, or when stabilizing a feature. Before
submitting substancial changes, we encourage contributors to contact the team on [Zulip] in order to
discuss such changes before submitting them for review.substancial changes This document aims to
Copy link
Contributor

@cyrgani cyrgani Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
discuss such changes before submitting them for review.substancial changes This document aims to
discuss such changes before submitting them for review. This document aims to

summarise the various processes that the compiler team has for making approval decisions and when
each should be used.

## Approvals
There are three mechanisms that the team can use to approve a proposal (not all approval mechanisms
Expand Down Expand Up @@ -71,16 +73,16 @@ the nature of the proposal, described below.
[major change template]: https://github.com/rust-lang/compiler-team/issues/new?template=major_change.md

#### What kinds of comments should go on a MCP in the compiler-team repo?
Please direct technical conversation to the Zulip stream.
Please direct technical conversation to the [Zulip] stream.

The compiler-team repo issues are intended to be low traffic and used for procedural purposes.

It is recommended that any team member who wishes to "second" a proposal be familiar with the
relevant code. Anyone can note concerns that shouldn't be overlooked.

#### How does one second an MCP or raise an objection?
These types of procedural comments can be left on the issue (it's also good to leave a message in
Zulip). See the previous section. To facilitate a machine parsable scanning of the concerns
These types of procedural comments can be left on the issue (it's also good to leave a message on
[Zulip]). See the previous section. To facilitate a machine parsable scanning of the concerns
please use the following syntax to formally register a concern:

```text
Expand Down Expand Up @@ -414,3 +416,4 @@ See [*Adding ecosystem/integration test jobs/components to rust-lang/rust CI*](.
[ecosystem_testing]: https://rustc-dev-guide.rust-lang.org/tests/ecosystem.html
[compiler-fcp]: https://github.com/rust-lang/team/blob/master/teams/compiler-fcp.toml
[tier-1-target-policy]: https://doc.rust-lang.org/rustc/target-tier-policy.html#tier-1-target-policy
[Zulip]: https://rust-lang.zulipchat.com
9 changes: 9 additions & 0 deletions src/how-to-start-contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,15 @@ official website for more resources.
**Please ask questions!** A lot of people report feeling that they are "wasting
expert time", but we do not feel that way. Contributors are important to us.

If you want to contribute substancial changes, please follow the recommended path of a Major
Change Proposal (MCP) or a Request For Comment (RFC) in order to have a prior discussion and
team buyout. You can learn more about what constitutes as "substancial" by reading the relevant
sections of the documentation for the [compiler][mcp-or-rcp-compiler] and for
[rustdoc][mcp-or-rcp-rustdoc].

[mcp-or-rcp-compiler]: compiler/proposals-and-stabilization.html
[mcp-or-rcp-rustdoc]: rustdoc/proposals-and-stabilization.html

Comment on lines +28 to +36
Copy link
Member

@Urgau Urgau Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section assumes that you want to contribute to the compiler, T-libs-api use ACP not MCPs, T-lang use experiments, ...

Copy link
Member

@jieyouxu jieyouxu Feb 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATM as well (not really for this PR but yeah):

  • T-rustdoc uses sth else (maybe just Zulip)?
  • T-bootstrap is just Zulip
  • T-infra is just Zulip

## How to start contributing?

The Rust project is quite large and it can be difficult to know which parts of the project need
Expand Down