Enable -Zdrop-tracking-mir by default by cjgillot · Pull Request #107421 · rust-lang/rust

cjgillot · 2023-01-28T18:45:54Z

This PR enables the drop-tracking-mir flag by default. This flag was initially implemented in #101692.

This flag computes auto-traits on generators based on their analysis MIR, instead of trying to compute on the HIR body. This removes the need for HIR-based drop-tracking, as we can now reuse the same code to compute generator witness types and to compute generator interior fields.

cjgillot · 2023-01-28T18:54:53Z

@bors try @rust-timer queue

bors · 2023-01-28T18:55:02Z

⌛ Trying commit 61c4d7edcd87bc38863fd1b164fccfc462431557 with merge 9ee0b0d5c433ffd332c5848d0dac8048d297b6ab...

bors · 2023-01-28T21:15:05Z

💔 Test failed - checks-actions

cjgillot · 2023-01-28T23:23:50Z

@bors try @rust-timer queue

bors · 2023-01-28T23:23:59Z

⌛ Trying commit b4f64e4054cd1a31c28ac024f2473973ac94bfdf with merge 549dafd0516c8b08f912fb001d48e977d0a94c34...

bors · 2023-01-29T01:33:56Z

☀️ Try build successful - checks-actions
Build commit: 549dafd0516c8b08f912fb001d48e977d0a94c34 (549dafd0516c8b08f912fb001d48e977d0a94c34)

bors · 2023-01-29T01:33:57Z

☀️ Try build successful - checks-actions
Build commit: 549dafd0516c8b08f912fb001d48e977d0a94c34 (549dafd0516c8b08f912fb001d48e977d0a94c34)

rust-timer · 2023-01-29T04:06:16Z

Finished benchmarking commit (549dafd0516c8b08f912fb001d48e977d0a94c34): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.5%, 1.1%]	4
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	2
Improvements ✅ (secondary)	-2.6%	[-5.4%, -1.1%]	11
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-2.7%	[-2.8%, -2.6%]	2
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-5.6%, -2.3%]	7
All ❌✅ (primary)	-	-	0

cjgillot · 2023-01-29T08:53:35Z

@craterbot check

craterbot · 2023-01-29T08:53:42Z

👌 Experiment pr-107421 created and queued.
🤖 Automatically detected try build 549dafd0516c8b08f912fb001d48e977d0a94c34
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2023-01-29T08:53:45Z

🚧 Experiment pr-107421 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

cjgillot · 2023-09-23T14:29:52Z

@bors r=oli-obk

bors · 2023-09-23T14:29:55Z

📌 Commit bffb346 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-09-23T18:28:05Z

⌛ Testing commit bffb346 with merge 13e6f24...

bors · 2023-09-23T20:16:00Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 13e6f24 to master...

rust-timer · 2023-09-23T22:30:52Z

Finished benchmarking commit (13e6f24): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.4%, 0.5%]	2
Regressions ❌ (secondary)	4.5%	[0.3%, 6.5%]	9
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	1
Improvements ✅ (secondary)	-2.5%	[-3.3%, -1.9%]	5
All ❌✅ (primary)	0.2%	[-0.4%, 0.5%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[1.0%, 5.4%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-4.6%, -1.5%]	7
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[2.7%, 5.4%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[1.6%, 7.6%]	7
Improvements ✅ (primary)	-0.5%	[-0.6%, -0.3%]	8
Improvements ✅ (secondary)	-8.8%	[-23.8%, -0.0%]	8
All ❌✅ (primary)	-0.5%	[-0.6%, -0.3%]	8

Bootstrap: 634.731s -> 631.479s (-0.51%)
Artifact size: 317.81 MiB -> 317.13 MiB (-0.21%)

rylev · 2023-09-26T18:55:06Z

@cjgillot @oli-obk it seems the regressions to await-call-tree are real. I'm having trouble running cachegrind right now. Do either of have any idea what might be causing this regression?

oli-obk · 2023-09-27T06:59:03Z

~~According to the graph, perf of await-call-tree went back to normal with the next perf run, or is the darker area on the graph just any perf run, instead of perf runs on master?~~

edit: oh this is the relative change, not the absolute value. oops

Kobzol · 2023-09-27T07:05:22Z

That's the second time in this week's triage that the "relativeness" of the graph tripped someone up. Would an absolute graph be more intuitive?

oli-obk · 2023-09-27T07:06:37Z

No ^^ I know that, and I read it correctly most of the time.

cachegrind:


--------------------------------------------------------------------------------
Ir        
--------------------------------------------------------------------------------
5,738,802  PROGRAM TOTALS

--------------------------------------------------------------------------------
Ir         file:function
--------------------------------------------------------------------------------
  328,796  ???:rustc_data_structures::graph::dominators::dominators::<rustc_middle::mir::basic_blocks::BasicBlocks>
 -294,357  ???:<rustc_middle::mir::basic_blocks::BasicBlocks>::dominators
  279,186  ???:<rustc_index::bit_set::BitSet<rustc_middle::mir::Local> as core::clone::Clone>::clone_from
  214,074  ???:<rustc_mir_dataflow::framework::GenKillSet<rustc_middle::mir::Local> as rustc_mir_dataflow::framework::GenKill<rustc_middle::mir::Local>>::kill
  198,319  /build/glibc-sMfBJT/glibc-2.31/string/../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:__memcpy_avx_unaligned_erms
  183,555  ???:<rustc_index::bit_set::BitSet<rustc_middle::mir::Local> as rustc_mir_dataflow::framework::lattice::JoinSemiLattice>::join
  179,652  ???:<rustc_infer::infer::combine::CombineFields>::instantiate
  179,298  ???:<rustc_infer::infer::equate::Equate as rustc_middle::ty::relate::TypeRelation>::regions
  163,674  ???:<alloc::vec::Vec<rustc_mir_dataflow::framework::GenKillSet<rustc_middle::mir::Local>>>::extend_with
 -161,957  ???:<rustc_infer::infer::region_constraints::RegionConstraintCollector>::make_eqregion
  142,882  ???:<rustc_mir_dataflow::impls::storage_liveness::MaybeRequiresStorage as rustc_mir_dataflow::framework::GenKillAnalysis>::terminator_effect
  139,495  ???:<smallvec::SmallVec<[u64; 2]> as core::iter::traits::collect::Extend<u64>>::extend::<core::iter::adapters::cloned::Cloned<core::slice::iter::Iter<u64>>>
  136,604  ???:<core::cell::once::OnceCell<alloc::vec::Vec<rustc_middle::mir::BasicBlock>>>::get_or_try_init::<<core::cell::once::OnceCell<alloc::vec::Vec<rustc_middle::mir::BasicBlock>>>::get_or_init<<rustc_middle::mir::basic_blocks::BasicBlocks>::reverse_postorder::{closure
  132,566  ???:<rustc_mir_transform::generator::StorageConflictVisitor>::apply_state
 -123,564  ???:<alloc::vec::Vec<rustc_middle::mir::BasicBlock> as alloc::vec::spec_from_iter::SpecFromIter<rustc_middle::mir::BasicBlock, core::iter::adapters::map::Map<rustc_middle::mir::traversal::Postorder, <rustc_middle::mir::basic_blocks::BasicBlocks>::reverse_postorder::{closure
  118,370  ???:<core::cell::once::OnceCell<rustc_index::vec::IndexVec<rustc_middle::mir::BasicBlock, smallvec::SmallVec<[rustc_middle::mir::BasicBlock; 4]>>>>::get_or_try_init::<<core::cell::once::OnceCell<rustc_index::vec::IndexVec<rustc_middle::mir::BasicBlock, smallvec::SmallVec<[rustc_middle::mir::BasicBlock; 4]>>>>::get_or_init<<rustc_middle::mir::basic_blocks::BasicBlocks>::predecessors::{closure
  114,764  ???:<rustc_mir_dataflow::framework::engine::Engine<rustc_mir_dataflow::impls::storage_liveness::MaybeRequiresStorage>>::iterate_to_fixpoint
  113,344  ???:<rustc_index::bit_set::BitSet<rustc_middle::mir::Local> as rustc_mir_dataflow::framework::BitSetExt<rustc_middle::mir::Local>>::subtract
 -111,672  ???:<rustc_infer::infer::sub::Sub as rustc_middle::ty::relate::TypeRelation>::tys
 -110,489  ???:<rustc_infer::infer::equate::Equate as rustc_middle::ty::relate::TypeRelation>::tys
  108,745  ???:rustc_middle::mir::traversal::reverse_postorder
  106,722  ???:<rustc_index::bit_set::BitMatrix<rustc_middle::mir::Local, rustc_middle::mir::Local>>::union_row_with
  102,612  ???:<rustc_mir_dataflow::impls::storage_liveness::MoveVisitor<rustc_index::bit_set::BitSet<rustc_middle::mir::Local>> as rustc_middle::mir::visit::Visitor>::visit_place
  101,417  ???:<&rustc_middle::ty::list::List<rustc_middle::ty::generic_args::GenericArg> as rustc_type_ir::fold::TypeFoldable<rustc_middle::ty::context::TyCtxt>>::try_fold_with::<rustc_infer::infer::freshen::TypeFreshener>

lots more small regressions that make up this 5 mil regression

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jan 28, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 28, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2023

cjgillot force-pushed the drop-tracking-mir branch from e71d2ed to b4f64e4 Compare January 28, 2023 23:23

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 29, 2023

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2023

cjgillot added 3 commits September 23, 2023 13:47

Remove useless wrapper.

855a75b

Remove GeneratorWitness and rename GeneratorWitnessMIR.

44ac8dc

Make test more robust to opts.

bffb346

bors mentioned this pull request Sep 23, 2023

Fix an assertion failure in bind_generator_hidden_types_above. #111085

Closed

cjgillot mentioned this pull request Sep 24, 2023

Remove dead diagnostic code for generators #116117

Merged

This was referenced Sep 24, 2023

DO NOT MERGE (yet): Enable -Zdrop-tracking by default #97334

Closed

WIP: Remove ResumeTy from async lowering #107562

Draft

tmandry mentioned this pull request Sep 28, 2023

Code no longer compiles after -Zdrop-tracking-mir was enabled by default #116242

Closed

lqd mentioned this pull request Oct 1, 2023

ICE: assertion failed: !hidden_types.has_erased_regions() #116306

Closed

fmease mentioned this pull request Oct 2, 2023

async function being !Send due to match retaining type of a consumed value. #114624

Closed

jackh726 mentioned this pull request Oct 11, 2023

Box syntax and generator_clone can lead to double free #105084

Closed

nnethercote mentioned this pull request Oct 30, 2023

ICE: unexpected region: RePlaceholder(Placeholder with mir drop tracking #110941

Closed

lqd mentioned this pull request Nov 2, 2023

regression: change in async capture rules? #117059

Closed

lukas-code mentioned this pull request Nov 20, 2023

Breaking change happened in rustc 1.74: lifetime error #118103

Closed

lqd mentioned this pull request Dec 18, 2023

ICE with "failed to resolve instance for <... as IntoFuture>::into_future: Ok(None)" (regression between 1.73 and 1.74) #119095

Open

lqd mentioned this pull request Dec 29, 2023

Add non-regression test for ATPIT ICE #114325 #119406

Merged

fmease mentioned this pull request Jan 26, 2024

Can't modify value after temporarily dropping reference in loop when using Drop #92984

Closed

jmagnuson mentioned this pull request Mar 28, 2024

Moved value is considered as held across an await in async fn #87309

Closed

compiler-errors mentioned this pull request Mar 28, 2024

async_fn_in_trait and return_type_notation cause awkward awaits #112569

Closed

xmh0511 mentioned this pull request Mar 29, 2024

Dropped variables still included in generator type #57478

Closed

m-ou-se mentioned this pull request Apr 11, 2025

Using the format!() macro with an async function makes the whole Future non-Send #101650

Closed

Uh oh!

Conversation

cjgillot commented Jan 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjgillot commented Jan 28, 2023

Uh oh!

This comment has been minimized.

bors commented Jan 28, 2023

Uh oh!

This comment has been minimized.

bors commented Jan 28, 2023

Uh oh!

cjgillot commented Jan 28, 2023

Uh oh!

This comment has been minimized.

bors commented Jan 28, 2023

Uh oh!

This comment has been minimized.

bors commented Jan 29, 2023

Uh oh!

bors commented Jan 29, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-timer commented Jan 29, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

cjgillot commented Jan 29, 2023

Uh oh!

craterbot commented Jan 29, 2023

Uh oh!

craterbot commented Jan 29, 2023

Uh oh!

cjgillot commented Sep 23, 2023

Uh oh!

bors commented Sep 23, 2023

Uh oh!

bors commented Sep 23, 2023

Uh oh!

bors commented Sep 23, 2023

Uh oh!

rust-timer commented Sep 23, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rylev commented Sep 26, 2023

Uh oh!

oli-obk commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Sep 27, 2023

Uh oh!

oli-obk commented Sep 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

cjgillot commented Jan 28, 2023 •

edited

Loading

oli-obk commented Sep 27, 2023 •

edited

Loading