Add `internal_features` lint by Noratrieb · Pull Request #108955 · rust-lang/rust

Noratrieb · 2023-03-09T21:38:07Z

Also requires some more test blessing for codegen tests etc

@jyn514 had the idea of just allowing the lint by default in the test suite. I'm not sure whether this is a good idea, but it's definitely one worth considering. Additional input encouraged.

rustbot · 2023-03-09T21:38:15Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

jyn514

❤️ ❤️

compiler/rustc_feature/src/active.rs

compiler/rustc_lint/locales/en-US.ftl

bors · 2023-03-12T07:39:59Z

☔ The latest upstream changes (presumably #108682) made this pull request unmergeable. Please resolve the merge conflicts.

tests/ui/abi/unsupported.rs

oli-obk · 2023-03-19T11:39:39Z

Does this affect any tools or backends? (modulo their tests, I just mean the tool/backend code)

Noratrieb · 2023-03-19T11:44:26Z

From a quick skim over them the tools and backends look fine as they don't use any features I classified as internal, but I'll make sure that they're fine when marking this as ready.

src/bootstrap/builder.rs

rustbot · 2023-07-08T20:25:57Z

The Miri subtree was changed

cc @rust-lang/miri

bors · 2023-07-17T20:28:03Z

☔ The latest upstream changes (presumably #113686) made this pull request unmergeable. Please resolve the merge conflicts.

Noratrieb · 2023-07-30T11:29:49Z

@rustbot ready

matthiaskrgr · 2023-07-30T11:36:23Z

compiler/rustc_feature/src/active.rs

shouldn't compiler_builtins be internal as well?

yeah there are many that could be internal too, I was mostly concerned with the ones that will cause ICEs if used incorectly
I added it too. But I don't think it's important to get this entirely right on this PR, we can always change things later. The most important thing is that lang_items, intrinsics, custom_mir and friends are marked as internal.

oli-obk · 2023-07-31T11:12:01Z

@bors r+

bors · 2023-07-31T11:12:03Z

📌 Commit d56a73f75430fa8ae92e97beb8a0e21713289ba5 has been approved by oli-obk

It is now in the queue for this repository.

Noratrieb · 2023-07-31T21:48:48Z

@bors rollup=iffy
my hopes that it passes first time are low

bors · 2023-08-01T03:05:31Z

⌛ Testing commit d56a73f75430fa8ae92e97beb8a0e21713289ba5 with merge 7b04a87c8d6942e2d3ff9651fa8d3f7ee1344859...

bors · 2023-08-01T03:53:09Z

💔 Test failed - checks-actions

Noratrieb · 2023-08-02T08:12:19Z

Blocked on the next cargo sync

weihanglo · 2023-08-03T06:20:22Z

Cargo update is live now.
#114364

It lints against features that are inteded to be internal to the compiler and standard library. Implements MCP rust-lang#596. We allow `internal_features` in the standard library and compiler as those use many features and this _is_ the standard library from the "internal to the compiler and standard library" after all. Marking some features as internal wasn't exactly the most scientific approach, I just marked some mostly obvious features. While there is a categorization in the macro, it's not very well upheld (should probably be fixed in another PR). We always pass `-Ainternal_features` in the testsuite About 400 UI tests and several other tests use internal features. Instead of throwing the attribute on each one, just always allow them. There's nothing wrong with testing internal features^^

Noratrieb · 2023-08-03T12:51:34Z

rebased (although that's technically unnecessary as the merge commit is tested)
@bors r=oli-obk

bors · 2023-08-03T12:51:36Z

📌 Commit 5830ca2 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-08-03T22:58:06Z

⌛ Testing commit 5830ca2 with merge 1fe3846...

bors · 2023-08-04T00:45:17Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 1fe3846 to master...

rust-timer · 2023-08-04T06:29:42Z

Finished benchmarking commit (1fe3846): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[1.7%, 3.7%]	5
Regressions ❌ (secondary)	2.3%	[1.4%, 3.2%]	2
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-1.7%	[-1.8%, -1.7%]	2
All ❌✅ (primary)	1.6%	[-2.6%, 3.7%]	6

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.938s -> 648.71s (-0.19%)

Noratrieb marked this pull request as draft March 9, 2023 21:38

rustbot assigned oli-obk Mar 9, 2023

rust-cloud-vms bot force-pushed the dont-use-me-pls branch from 459a156 to 4a6dcbf Compare March 9, 2023 21:39

jyn514 reviewed Mar 9, 2023

View reviewed changes

compiler/rustc_feature/src/active.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/locales/en-US.ftl Outdated Show resolved Hide resolved

workingjubilee mentioned this pull request Mar 16, 2023

Guide for fuzzer-users rust-lang/rustc-dev-guide#1645

Closed

Noratrieb force-pushed the dont-use-me-pls branch from 4a6dcbf to 056c70e Compare March 18, 2023 18:13

This comment has been minimized.

Sign in to view

oli-obk reviewed Mar 19, 2023

View reviewed changes

tests/ui/abi/unsupported.rs Outdated Show resolved Hide resolved

rust-cloud-vms bot force-pushed the dont-use-me-pls branch from 056c70e to d621602 Compare March 19, 2023 17:17

Noratrieb removed A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Mar 19, 2023

jyn514 reviewed Mar 19, 2023

View reviewed changes

src/bootstrap/builder.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rust-cloud-vms bot force-pushed the dont-use-me-pls branch from d621602 to 4c96d31 Compare March 19, 2023 17:46

rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Mar 19, 2023

This comment has been minimized.

Sign in to view

Noratrieb removed A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic labels Mar 19, 2023

Noratrieb force-pushed the dont-use-me-pls branch from 478fbdd to 77105b9 Compare July 8, 2023 20:25

This comment has been minimized.

Sign in to view

workingjubilee mentioned this pull request Jul 11, 2023

ICE: rustdoc json when #[doc(primitive)] mod name is same as primitive name. #102363

Closed

compiler-errors mentioned this pull request Jul 13, 2023

Why isn't the unsafe keyword necessary for custom MIR? #113664

Closed

matthiaskrgr reviewed Jul 30, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

Noratrieb mentioned this pull request Aug 1, 2023

#[allow(internal_features)] in RUSTC_BOOTSTRAP test rust-lang/cargo#12429

Merged

This was referenced Aug 4, 2023

rustdoc: Add lint redundant_explicit_links #113167

Merged

Unstable Book: update lang_items page and split it #113715

Merged

Convert builtin "global" late lints to run per module #113734

Merged

nbdd0121 mentioned this pull request Aug 5, 2023

Initial libstd support nbdd0121/unwinding#17

Merged

ehuss mentioned this pull request Aug 5, 2023

Add allow(internal_features) rust-lang/cargo#12450

Merged

klensy mentioned this pull request Aug 7, 2023

update to edition 2018, allow internal_features rust-lang/compiler-builtins#547

Merged

Uh oh!

Conversation

Noratrieb commented Mar 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 9, 2023

Uh oh!

jyn514 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bors commented Mar 12, 2023

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Mar 19, 2023

Uh oh!

Noratrieb commented Mar 19, 2023

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Jul 8, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Jul 17, 2023

Uh oh!

Noratrieb commented Jul 30, 2023

Uh oh!

matthiaskrgr Jul 30, 2023

Choose a reason for hiding this comment

Uh oh!

Noratrieb Jul 30, 2023

Choose a reason for hiding this comment

Uh oh!

oli-obk commented Jul 31, 2023

Uh oh!

bors commented Jul 31, 2023

Uh oh!

Noratrieb commented Jul 31, 2023

Uh oh!

bors commented Aug 1, 2023

Uh oh!

This comment has been minimized.

bors commented Aug 1, 2023

Uh oh!

Noratrieb commented Aug 2, 2023

Uh oh!

weihanglo commented Aug 3, 2023

Uh oh!

Noratrieb commented Aug 3, 2023

Uh oh!

bors commented Aug 3, 2023

Uh oh!

bors commented Aug 3, 2023

Uh oh!

bors commented Aug 4, 2023

Uh oh!

rust-timer commented Aug 4, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Noratrieb commented Mar 9, 2023 •

edited

Loading