Add rustc_fluent_macro to decouple fluent from rustc_macros#110407
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 19, 2023
Merged
Add rustc_fluent_macro to decouple fluent from rustc_macros#110407bors merged 1 commit intorust-lang:masterfrom
rustc_fluent_macro to decouple fluent from rustc_macros#110407bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fluent, with all the icu4x it brings in, takes quite some time to compile.
fluent_messages!is only needed in further downstream rustc crates, but is blocking more upstream crates likerustc_index. By splitting it out, we allowrustc_macrosto be compiled earlier, which speeds upx check compilerby about 5 seconds (and even more after the needless dependency onserde_jsonis removed fromrustc_data_structures).